Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tree-view.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ class TreeView

# return early if we're opening a contextual menu (right click) during multi-select mode
if @multiSelectEnabled() and
e.target.classList.contains('selected') and
entryToSelect.classList.contains('selected') and
# mouse right click or ctrl click as right click on darwin platforms
(e.button is 2 or e.ctrlKey and process.platform is 'darwin')
return
Expand Down
34 changes: 34 additions & 0 deletions spec/tree-view-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,38 @@ describe('TreeView', () => {
)
})
})

describe('clicking', () => {
it('should leave multiple entries selected on right click', () => {
const treeView = new TreeView({})
const entries = treeView.roots[0].entries

treeView.onMouseDown({
stopPropagation() {},
target: entries.children[0],
button: 0,
})

treeView.onMouseDown({
stopPropagation() {},
target: entries.children[1],
button: 0,
metaKey: true,
})

let child = entries.children[0];
while (child.children.length > 0) {
child = child.firstChild;
}

treeView.onMouseDown({
stopPropagation() {},
target: child,
button: 2,
})

expect(treeView.getSelectedEntries().length).toBe(2);
expect(treeView.multiSelectEnabled()).toBe(true);
})
});
})