Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

The git identity panel introduced in #2428 flips on automatically when the username or email are not set in your git config, but an empty (uninitialized) or absent (no working directories) repository would never have either. Let's only show the git identity panel when the repository is actually present.

Applicable Issues

Fixes #2435.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #2437 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
+ Coverage   93.11%   93.43%   +0.31%     
==========================================
  Files         236      236              
  Lines       13196    13196              
  Branches     1897     1897              
==========================================
+ Hits        12288    12330      +42     
+ Misses        908      866      -42     
Impacted Files Coverage Δ
lib/controllers/git-tab-controller.js 85.71% <ø> (ø)
lib/git-shell-out-strategy.js 99.81% <0.00%> (+0.56%) ⬆️
lib/atom/gutter.js 92.85% <0.00%> (+2.38%) ⬆️
lib/helpers.js 89.30% <0.00%> (+2.88%) ⬆️
lib/models/file-system-change-observer.js 96.00% <0.00%> (+8.00%) ⬆️
lib/shared/keytar-strategy.js 58.13% <0.00%> (+19.37%) ⬆️
lib/models/repository-states/empty.js 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86be963...f4a7aa2. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git identity panel stuck on in a non-git repo

2 participants