Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Git identity panel stuck on in a non-git repo #2435

@smashwilson

Description

@smashwilson

Prerequisites

Description

When Atom is opened with a project root that is not a git repository, the "Git Identity" view is always shown (with empty username and email) even when both are set in the global config.

Steps to Reproduce

  1. mkdir -p ~/src/not-git
  2. atom ~/src/not-git

Expected behavior:

The "initialize a repo here" pane should be visible.

Actual behavior:

The "Git identity" pane is visible.

Reproduces how often:

100%

Versions

$ atom --version                                                                                                               
Atom    : 1.46.0-nightly7
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0
$ apm --version                                                                                                                          
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.46.0-nightly7
python 2.7.16
git 2.24.1

Additional Information

My guess is that this is caused by the default implementation of State#getConfig() in non-Present repository states.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions