Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Retry known test flakes #1765

Merged
merged 6 commits into from
Oct 29, 2018
Merged

Retry known test flakes #1765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32e6984
Flakes reported in #761
smashwilson Oct 29, 2018
8d8fe0b
Reported as #1743
smashwilson Oct 29, 2018
f3a2c7d
Reported as #1698
smashwilson Oct 29, 2018
a46d41f
Reported as #1688
smashwilson Oct 29, 2018
f50a3d5
Reported as #731
smashwilson Oct 29, 2018
4826e20
Retry flakey file patch test
kuychaco Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/git-strategies.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,6 +1457,8 @@ import * as reporterProxy from '../lib/reporter-proxy';
}

it('prompts for authentication data through Atom', async function() {
this.retries(5); // FLAKE

let query = null;
const git = await withHttpRemote({
prompt: q => {
Expand Down Expand Up @@ -1516,6 +1518,8 @@ import * as reporterProxy from '../lib/reporter-proxy';
});

it('prefers user-configured credential helpers if present', async function() {
this.retries(5); // FLAKE

let query = null;
const git = await withHttpRemote({
prompt: q => {
Expand Down
4 changes: 4 additions & 0 deletions test/github-package.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,8 @@ describe('GithubPackage', function() {
let workdirPath2, atomGitRepository2, repository2;

beforeEach(async function() {
this.retries(5); // FLAKE
Copy link
Contributor

@kuychaco kuychaco Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smashwilson do we actually want this in the beforeEach? Is the goal with this to retry all of the tests in this describe block?

Copy link
Contributor Author

@smashwilson smashwilson Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent was to retry the beforeEach itself if it throws. I was going off of #761 which puts the failure there instead of within any of the specific tests.

I'm... not actually sure if that's what Mocha will do here, though? The documentation doesn't make it clear. It doesn't break though?


[workdirPath1, workdirPath2] = await Promise.all([
cloneRepository('three-files'),
cloneRepository('three-files'),
Expand Down Expand Up @@ -645,6 +647,7 @@ describe('GithubPackage', function() {
if (process.platform === 'linux') {
this.skip();
}
this.retries(5); // FLAKE

fs.writeFileSync(path.join(workdirPath1, 'a.txt'), 'some changes', 'utf8');

Expand All @@ -656,6 +659,7 @@ describe('GithubPackage', function() {
if (process.platform === 'linux') {
this.skip();
}
this.retries(5); // FLAKE

fs.writeFileSync(path.join(workdirPath2, 'b.txt'), 'other changes', 'utf8');

Expand Down
2 changes: 2 additions & 0 deletions test/integration/file-patch.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,8 @@ describe('integration: file patches', function() {
});

it('may be partially staged', async function() {
this.retries(5); // FLAKE

getPatchEditor('unstaged', 'sample.js').setSelectedBufferRanges([
[[2, 0], [2, 0]],
[[10, 0], [10, 0]],
Expand Down
2 changes: 2 additions & 0 deletions test/models/file-system-change-observer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ describe('FileSystemChangeObserver', function() {
});

it('emits an event when a project file is modified, created, or deleted', async function() {
this.retries(5); // FLAKE

const workdirPath = await cloneRepository('three-files');
const repository = await buildRepository(workdirPath);
observer = createObserver(repository);
Expand Down
2 changes: 2 additions & 0 deletions test/worker-manager.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ describe('WorkerManager', function() {

describe('when the manager process is destroyed', function() {
it('destroys all the renderer processes that were created', async function() {
this.retries(5); // FLAKE

const browserWindow = new BrowserWindow({show: !!process.env.ATOM_GITHUB_SHOW_RENDERER_WINDOW});
browserWindow.loadURL('about:blank');
sinon.stub(Worker.prototype, 'getWebContentsId').returns(browserWindow.webContents.id);
Expand Down