This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Retry known test flakes #1765
Merged
Retry known test flakes #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuychaco
reviewed
Oct 30, 2018
| let workdirPath2, atomGitRepository2, repository2; | ||
|
|
||
| beforeEach(async function() { | ||
| this.retries(5); // FLAKE |
Contributor
There was a problem hiding this comment.
@smashwilson do we actually want this in the beforeEach? Is the goal with this to retry all of the tests in this describe block?
Contributor
Author
There was a problem hiding this comment.
My intent was to retry the beforeEach itself if it throws. I was going off of #761 which puts the failure there instead of within any of the specific tests.
I'm... not actually sure if that's what Mocha will do here, though? The documentation doesn't make it clear. It doesn't break though?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag known test flakes with
this.retries(5)to limit the pain until we can schedule time to work them down again. Each of these flakes has already been filed with an issue labelled flaky-test.