Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@aminya
Copy link
Contributor

@aminya aminya commented Sep 15, 2020

Description of the change:

  • require acorn only once
  • improve warning message slightly
  • test on electron 9
  • bump other dependencies
  • remove not-needed babel (async/await is supported in Node)

Verification

Closes #29
Closes #28

@aminya
Copy link
Contributor Author

aminya commented Sep 15, 2020

@sadick254 Could you merge this and register a new version? My last PR has not been registered yet, which blocks atom/atom#20965

aminya added a commit to atom-community/atom that referenced this pull request Oct 31, 2020
@aminya aminya mentioned this pull request Oct 31, 2020
2 tasks
aminya added a commit to atom-community/atom that referenced this pull request Oct 31, 2020
@aminya aminya mentioned this pull request Dec 10, 2020
58 tasks
Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@sadick254 sadick254 merged commit 6889fa2 into atom:master Dec 10, 2020
aminya added a commit to atom-community/atom that referenced this pull request Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants