This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Lazy require fix #27
Merged
Lazy require fix #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
lazyRequireFix
branch
2 times, most recently
from
75ff450 to
1a46285
Compare
Contributor
|
Thanks @aminya for the contribution 🙇 |
Merged
aminya
added a commit
to atom-community/atom
that referenced
this pull request
Oct 31, 2020
This includes these PRs: atom/electron-link#27 (Crucial) atom/electron-link#26 atom/electron-link#31
aminya
added a commit
to atom-community/atom
that referenced
this pull request
Oct 31, 2020
This includes these PRs: atom/electron-link#27 (Crucial) atom/electron-link#26 atom/electron-link#31
aminya
added a commit
to atom-community/atom
that referenced
this pull request
Jan 27, 2021
This includes these PRs: atom/electron-link#27 (Crucial) atom/electron-link#26 atom/electron-link#31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2! 😃
Two reasons that #2 error happened are fixed:
Now we handle those situations instead of throwing error.
cc: @lkashef @smashwilson
This will solve the issue in atom/atom#20965