Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sphinx_automodapi/autodoc_enhancements.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
"""
Miscellaneous enhancements to help autodoc along.
"""
import dataclasses

from sphinx.ext.autodoc import AttributeDocumenter

__all__ = []
Expand Down Expand Up @@ -58,7 +60,14 @@ def type_object_attrgetter(obj, attr, *defargs):
return base.__dict__[attr]
break

return getattr(obj, attr, *defargs)
try:
return getattr(obj, attr, *defargs)
except AttributeError:
# for dataclasses, get the attribute from the __dataclass_fields__
if dataclasses.is_dataclass(obj) and attr in obj.__dataclass_fields__:
return obj.__dataclass_fields__[attr].default
else:
raise


def setup(app):
Expand Down
14 changes: 13 additions & 1 deletion sphinx_automodapi/automodsumm.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
import inspect
import os
import re
import dataclasses

import sphinx
from docutils.parsers.rst.directives import flag
Expand Down Expand Up @@ -595,11 +596,22 @@
else:
names = getattr(obj, '__dict__').keys()

# add dataclass_field names for dataclass classes
if dataclasses.is_dataclass(obj):
dataclass_fieldnames = getattr(obj, '__dataclass_fields__').keys()
names = list(set(list(names) + list(dataclass_fieldnames)))

Check warning on line 602 in sphinx_automodapi/automodsumm.py

View check run for this annotation

Codecov / codecov/patch

sphinx_automodapi/automodsumm.py#L601-L602

Added lines #L601 - L602 were not covered by tests

for name in names:
try:
documenter = get_documenter(app, safe_getattr(obj, name), obj)
except AttributeError:
continue
# for dataclasses try to get the attribute from the __dataclass_fields__
if dataclasses.is_dataclass(obj):
try:
attr = obj.__dataclass_fields__[name]
documenter = get_documenter(app, attr, obj)
except KeyError:
continue

Check warning on line 614 in sphinx_automodapi/automodsumm.py

View check run for this annotation

Codecov / codecov/patch

sphinx_automodapi/automodsumm.py#L609-L614

Added lines #L609 - L614 were not covered by tests
if typ is None or documenter.objtype == typ:
items.append(name)
# elif typ == 'attribute' and documenter.objtype == 'property':
Expand Down
17 changes: 17 additions & 0 deletions sphinx_automodapi/tests/test_autodoc_enhancements.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,20 @@ def test_type_attrgetter():

assert type_object_attrgetter(MyClass, 'susy', 'default') == 'default'
assert type_object_attrgetter(MyClass, '__dict__') == MyClass.__dict__


def test_type_attrgetter_for_dataclass():
"""
This tests the attribute getter for non-default dataclass fields
"""
import dataclasses

@dataclasses.dataclass
class MyDataclass:
foo: int
bar: str = "bar value"

with pytest.raises(AttributeError):
getattr(MyDataclass, 'foo')
assert type_object_attrgetter(MyDataclass, 'foo') == dataclasses.MISSING
assert getattr(MyDataclass, 'bar') == 'bar value'
Loading