-
-
Notifications
You must be signed in to change notification settings - Fork 49
Support for non-default dataclass fields (continuation of stale PR, https://github.com/astropy/sphinx-automodapi/pull/116) #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 90.05% 89.69% -0.37%
==========================================
Files 31 31
Lines 1227 1252 +25
==========================================
+ Hits 1105 1123 +18
- Misses 122 129 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lpsinger. This PR slipped through the cracks multiple times for no apparent reasons, thanks for resurrecting and finishing it up.
|
@bsipocz, would you please do a release to pick up this change? |
|
Aye, I'll cut one later this afternoon. Thanks for the ping. |
|
Release is on pypi, conda-forge can take a few hours to follow. |
ifstatements as requested by @bsipocz (Support for non-default dataclass fields #116 (comment), Support for non-default dataclass fields #116 (comment)).dataclasses.MISSINGrather than incorrectly reporting the name of the field as the default value.