Skip to content

Remove redundant Equatable conformances in code generation #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Remove redundant Equatable conformances in code generation #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/_OpenAPIGeneratorCore/FeatureFlags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
/// enabled unconditionally on main and the feature flag removed, and version
/// 0.2 is tagged. (This is for pre-1.0 versioning, would be 1.0 and 2.0 after
/// 1.0 is released.)
public enum FeatureFlag: String, Hashable, Equatable, Codable, CaseIterable {
public enum FeatureFlag: String, Hashable, Codable, CaseIterable {

/// Multiple request and response body content types.
///
Expand Down
7 changes: 0 additions & 7 deletions Sources/_OpenAPIGeneratorCore/Translator/CommonTypes/Constants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ enum Constants {
/// The types that every struct conforms to.
static let conformances: [String] = [
"Codable",
"Equatable",
"Hashable",
"Sendable",
]
Expand All @@ -154,7 +153,6 @@ enum Constants {
/// The types that every enum conforms to.
static let conformances: [String] = [
"Codable",
"Equatable",
"Hashable",
"Sendable",
"_AutoLosslessStringConvertible",
Expand Down Expand Up @@ -208,7 +206,6 @@ enum Constants {
/// The types that the body conforms to.
static let conformances: [String] = [
"Sendable",
"Equatable",
"Hashable",
]
}
Expand All @@ -225,7 +222,6 @@ enum Constants {
/// The types that the Input type conforms to.
static let conformances: [String] = [
"Sendable",
"Equatable",
"Hashable",
]
}
Expand All @@ -239,7 +235,6 @@ enum Constants {
/// The types that the Output type conforms to.
static let conformances: [String] = [
"Sendable",
"Equatable",
"Hashable",
]

Expand All @@ -249,7 +244,6 @@ enum Constants {
/// The types that the Payload type conforms to.
static let conformances: [String] = [
"Sendable",
"Equatable",
"Hashable",
]

Expand All @@ -272,7 +266,6 @@ enum Constants {
/// The types that the Headers type conforms to.
static let conformances: [String] = [
"Sendable",
"Equatable",
"Hashable",
]
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/_OpenAPIGeneratorCore/Translator/Content/CodingStrategy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
//===----------------------------------------------------------------------===//

/// Describes the underlying coding strategy.
enum CodingStrategy: String, Equatable, Hashable, Sendable {
enum CodingStrategy: String, Hashable, Sendable {

/// A strategy using JSONEncoder/JSONDecoder.
case json
Expand Down
2 changes: 1 addition & 1 deletion Tests/OpenAPIGeneratorReferenceTests/FileBasedReferenceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class FileBasedReferenceTests: XCTestCase {
}
}

struct ReferenceProject: Hashable, Equatable {
struct ReferenceProject: Hashable {
var name: ReferenceProjectName
var customDirectoryName: String? = nil

Expand Down
235 changes: 117 additions & 118 deletions Tests/OpenAPIGeneratorReferenceTests/Resources/ReferenceSources/Petstore/Types.swift
View file
Open in desktop

Large diffs are not rendered by default.

233 changes: 116 additions & 117 deletions ...torReferenceTests/Resources/ReferenceSources/Petstore_FF_MultipleContentTypes/Types.swift
View file
Open in desktop

Large diffs are not rendered by default.

112 changes: 56 additions & 56 deletions Tests/OpenAPIGeneratorReferenceTests/SnippetBasedReferenceTests.swift
View file
Open in desktop

Large diffs are not rendered by default.