Remove redundant Equatable conformances in code generation #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurcro
changed the title
arthurcro
changed the title
|
This looks great, @arthurcro . Could you also audit the runtime library please? 🙏 |
|
@swift-server-bot add to allowlist |
|
@czechboy0 Yes, definitely! I actually have the changes ready for the runtime library on a local branch! I'll open a pull request for it today! 🙂 |
czechboy0
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #210.
Modifications
With this PR. we are removing the explicit
Equatableconformance when a type already conforms toHashablein generated code.
Result
Generated types now conforms explicitly to
Hashablebut not toEquatable.Test Plan
I have updated the reference ressources used by tests to check generated code.