Singleton: address feedback in #311 #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#311 (comment) Maybe #346
yim-lee
commented
Dec 25, 2019
| // No leader so singleton is not available, messages sent should be stashed | ||
| ref2.tell(.greet(name: "Charlie-2", _replyTo: replyProbe2.ref)) | ||
| ref3.tell(.greet(name: "Charlie-3", _replyTo: replyProbe2.ref)) | ||
| ref3.tell(.greet(name: "Charlie-3", _replyTo: replyProbe3.ref)) |
Member
Author
There was a problem hiding this comment.
bug 🙀
I don't know how the test was passing locally for me (with ActorTestKit(system), it started failing always when I changed to self.testKit(system))...
Member
There was a problem hiding this comment.
huh yeah unexpected that this had worked 🤔
Good catch!
This was referenced Dec 25, 2019
Closed
ktoso
reviewed
Dec 26, 2019
| if leaderNode != expectedNode { | ||
| throw testKit.error("Expected \(reflecting: expectedNode) to be leader node on \(reflecting: system.cluster.node) but was [\(reflecting: leaderNode)]") | ||
| } | ||
| } |
ktoso
reviewed
Dec 26, 2019
|
|
||
| override func tearDown() { | ||
| self.logCaptureHandler.printIfFailed(self.testRun) | ||
| } |
ktoso
reviewed
Dec 26, 2019
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Good improvements thanks!
Technically "tiny race" remains I believe -- the cluster may know already that we're leaderless but the singleton may still receive the message we send it before it gets the info that it is leaderless. This definitely improves robustness of this test though - Thanks!
ktoso
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address review comments in #311.