standardize formatting #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: prepare for CI changes: * add default swiftformat settings and apply them * update linux generation script to conform to formatting rules
ktoso
reviewed
Aug 21, 2019
Member
There was a problem hiding this comment.
that's the only thing which I'd like the formatter not to do 🤔
ktoso
reviewed
Aug 21, 2019
Member
There was a problem hiding this comment.
that's cool, we wanted that since a while but never got to set up 👍
ktoso
reviewed
Aug 21, 2019
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
I'm happy with this, the only thing that would be good for this not to break is:
// ==== ------------------------------------------------------------------------------------------------------------
// MARK: ActorShell implementation
where it now adds a newline between those 😢
Member
|
Let's merge and follow up any failures / fixups one by one |
ktoso
pushed a commit
that referenced
this pull request
Aug 31, 2019
motivation: prepare for CI changes: * add default swiftformat settings and apply them * update linux generation script to conform to formatting rules
ktoso
added a commit
that referenced
this pull request
Dec 25, 2019
ktoso
added a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: prepare for CI
changes: