Skip to content

RACE: accessing cell during traversal #702

New issue
New issue
Closed
Closed
RACE: accessing cell during traversal#702
Labels
2 - pick nextIf looking for work, pick this ticket :-)kind/bugFeature doesn't work as expected.t:actor
Milestone
0.6.10
@ktoso

Description

@ktoso
ktoso
opened on Jun 25, 2020

Seems the locks are wrong

13:20:02 - 2020-06-25 13:20:02.129 - Test Case '-[DistributedActorsTests.TraversalTests test_traverse_shouldHaveRightDepthInContext]' started.
13:20:02 - 2020-06-25 13:20:02.129 - ==================
13:20:02 - 2020-06-25 13:20:02.129 - WARNING: ThreadSanitizer: data race (pid=75254)
13:20:02 - 2020-06-25 13:20:02.129 -   Read of size 8 at 0x7b5000210d48 by main thread:
13:20:02 - 2020-06-25 13:20:02.129 -     #0 ActorShell._myCell.getter ActorShell.swift (swift-distributed-actorsPackageTests:x86_64+0x4fb4f2)
13:20:02 - 2020-06-25 13:20:02.129 -     #1 ActorShell.myself.getter ActorShell.swift:221 (swift-distributed-actorsPackageTests:x86_64+0x4fbd17)
13:20:02 - 2020-06-25 13:20:02.129 -     #2 ActorShell.asAddressable.getter ActorShell.swift:88 (swift-distributed-actorsPackageTests:x86_64+0x4fbf0b)
13:20:02 - 2020-06-25 13:20:02.129 -     #3 protocol witness for AbstractActor.asAddressable.getter in conformance ActorShell<A> <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x51c8f3)
13:20:02 - 2020-06-25 13:20:02.129 -     #4 AbstractActor._traverse<A>(context:_:) ActorShell.swift:948 (swift-distributed-actorsPackageTests:x86_64+0x51cde3)
13:20:02 - 2020-06-25 13:20:02.129 -     #5 protocol witness for _ActorTreeTraversable._traverse<A>(context:_:) in conformance ActorShell<A> <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x51c979)
13:20:02 - 2020-06-25 13:20:02.129 -     #6 Children._traverse<A>(context:_:) ActorShell+Children.swift:216 (swift-distributed-actorsPackageTests:x86_64+0x4f20f0)
13:20:02 - 2020-06-25 13:20:02.129 -     #7 AbstractActor._traverse<A>(context:_:) ActorShell.swift:950 (swift-distributed-actorsPackageTests:x86_64+0x51cf30)
13:20:02 - 2020-06-25 13:20:02.129 -     #8 protocol witness for _ActorTreeTraversable._traverse<A>(context:_:) in conformance ActorShell<A> <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x51c979)
13:20:02 - 2020-06-25 13:20:02.129 -     #9 Children._traverse<A>(context:_:) ActorShell+Children.swift:216 (swift-distributed-actorsPackageTests:x86_64+0x4f20f0)
13:20:02 - 2020-06-25 13:20:02.129 -     #10 Guardian._traverse<A>(context:_:) Refs.swift:682 (swift-distributed-actorsPackageTests:x86_64+0xbf8178)
13:20:02 - 2020-06-25 13:20:02.129 -     #11 LocalActorRefProvider._traverse<A>(context:_:) ActorRefProvider.swift:183 (swift-distributed-actorsPackageTests:x86_64+0x4e1822)
13:20:02 - 2020-06-25 13:20:02.129 -     #12 protocol witness for _ActorTreeTraversable._traverse<A>(context:_:) in conformance LocalActorRefProvider <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x4e2624)
13:20:02 - 2020-06-25 13:20:02.129 -     #13 ActorSystem._traverse<A>(context:_:) ActorSystem.swift:596 (swift-distributed-actorsPackageTests:x86_64+0x53bbbe)
13:20:02 - 2020-06-25 13:20:02.129 -     #14 ActorSystem._traverseAll<A>(_:) ActorSystem.swift:618 (swift-distributed-actorsPackageTests:x86_64+0x53c6c7)
13:20:02 - 2020-06-25 13:20:02.129 -     #15 TraversalTests.test_traverse_shouldHaveRightDepthInContext() TraversalTests.swift:120 (swift-distributed-actorsPackageTests:x86_64+0x15dc124)
13:20:02 - 2020-06-25 13:20:02.129 -     #16 @objc TraversalTests.test_traverse_shouldHaveRightDepthInContext() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x15dc7a4)
13:20:02 - 2020-06-25 13:20:02.129 -     #17 __invoking___ <null> (CoreFoundation:x86_64+0x4a0eb)
13:20:02 - 2020-06-25 13:20:02.129 -   Previous write of size 8 at 0x7b5000210d48 by thread T140 (mutexes: write M344895):
13:20:02 - 2020-06-25 13:20:02.129 -     #0 ActorShell._myCell.setter ActorShell.swift (swift-distributed-actorsPackageTests:x86_64+0x4fb949)
13:20:02 - 2020-06-25 13:20:02.129 -     #1 ActorShell.set(ref:) ActorShell.swift:191 (swift-distributed-actorsPackageTests:x86_64+0x5015d0)
13:20:02 - 2020-06-25 13:20:02.129 -     #2 ActorShell._spawn<A>(_:props:_:) ActorShell+Children.swift:364 (swift-distributed-actorsPackageTests:x86_64+0x4f6867)
13:20:02 - 2020-06-25 13:20:02.129 -     #3 ActorShell.spawn<A>(_:of:props:file:line:_:) ActorShell.swift:630 (swift-distributed-actorsPackageTests:x86_64+0x514aa0)
13:20:02 - 2020-06-25 13:20:02.129 -     #4 protocol witness for ActorRefFactory.spawn<A>(_:of:props:file:line:_:) in conformance ActorContext<A> <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x4ad0ef)
13:20:02 - 2020-06-25 13:20:02.129 -     #5 static Gossiper.spawn<A, B, C>(_:name:settings:props:makeLogic:) Gossiper.swift:40 (swift-distributed-actorsPackageTests:x86_64+0xa80262)
13:20:02 - 2020-06-25 13:20:02.129 -     #6 closure #1 in CRDT.Replicator.Shell.behavior.getter CRDT+ReplicatorShell.swift:74 (swift-distributed-actorsPackageTests:x86_64+0x5c7bb0)
13:20:02 - 2020-06-25 13:20:02.129 -     #7 partial apply for closure #1 in CRDT.Replicator.Shell.behavior.getter <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x5c7ea2)
13:20:02 - 2020-06-25 13:20:02.129 -     #8 start0 #1 <A>(_:depth:) in Behavior.start(context:) Behaviors.swift:762 (swift-distributed-actorsPackageTests:x86_64+0x572558)
13:20:02 - 2020-06-25 13:20:02.129 -     #9 Behavior.start(context:) Behaviors.swift:780 (swift-distributed-actorsPackageTests:x86_64+0x56ca16)
13:20:02 - 2020-06-25 13:20:02.129 -     #10 Supervisor.interpretSupervised0(target:context:processingAction:nFoldFailureDepth:) Supervision.swift:465 (swift-distributed-actorsPackageTests:x86_64+0xc9cfb5)
13:20:02 - 2020-06-25 13:20:02.129 -     #11 Supervisor.interpretSupervised0(target:context:processingAction:) Supervision.swift:457 (swift-distributed-actorsPackageTests:x86_64+0xc9a7c4)
13:20:02 - 2020-06-25 13:20:02.129 -     #12 Supervisor.startSupervised(target:context:) Supervision.swift:451 (swift-distributed-actorsPackageTests:x86_64+0xc9ca00)
13:20:02 - 2020-06-25 13:20:02.129 -     #13 ActorShell.interpretStart() ActorShell.swift:506 (swift-distributed-actorsPackageTests:x86_64+0x505af5)
13:20:02 - 2020-06-25 13:20:02.129 -     #14 ActorShell.interpretSystemMessage(message:) ActorShell.swift:306 (swift-distributed-actorsPackageTests:x86_64+0x503ff8)
13:20:02 - 2020-06-25 13:20:02.129 -     #15 Mailbox.mailboxRun(_:) Mailbox.swift:386 (swift-distributed-actorsPackageTests:x86_64+0xab445b)
13:20:02 - 2020-06-25 13:20:02.129 -     #16 Mailbox.run() Mailbox.swift:331 (swift-distributed-actorsPackageTests:x86_64+0xaac514)
13:20:02 - 2020-06-25 13:20:02.129 -     #17 partial apply for Mailbox.run() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xac19df)
13:20:02 - 2020-06-25 13:20:02.129 -     #18 thunk for @escaping @callee_guaranteed () -> () <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x55d267)
13:20:02 - 2020-06-25 13:20:02.129 -     #19 partial apply for thunk for @escaping @callee_guaranteed () -> () <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa32e0d)
13:20:02 - 2020-06-25 13:20:02.129 -     #20 thunk for @escaping @callee_guaranteed () -> (@out ()) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x55d827)
13:20:02 - 2020-06-25 13:20:02.129 -     #21 partial apply for thunk for @escaping @callee_guaranteed () -> (@out ()) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa330a5)
13:20:02 - 2020-06-25 13:20:02.129 -     #22 closure #1 in FixedThreadPool.init(_:) FixedThreadPool.swift:75 (swift-distributed-actorsPackageTests:x86_64+0xa32652)
13:20:02 - 2020-06-25 13:20:02.129 -     #23 partial apply for closure #1 in FixedThreadPool.init(_:) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa32895)
13:20:02 - 2020-06-25 13:20:02.129 -     #24 closure #1 in Thread.init(_:) Thread.swift:53 (swift-distributed-actorsPackageTests:x86_64+0xcb649a)
13:20:02 - 2020-06-25 13:20:02.129 -     #25 partial apply for closure #1 in Thread.init(_:) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xcb657d)
13:20:02 - 2020-06-25 13:20:02.129 -     #26 closure #1 in static Thread.runnerCallback.getter Thread.swift:132 (swift-distributed-actorsPackageTests:x86_64+0xcb7e3f)
13:20:02 - 2020-06-25 13:20:02.129 -     #27 @objc closure #1 in static Thread.runnerCallback.getter <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xcb7f10)
13:20:02 - 2020-06-25 13:20:02.129 -   Location is heap block of size 512 at 0x7b5000210c00 allocated by thread T140:
13:20:02 - 2020-06-25 13:20:02.129 -     #0 malloc <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x4fd3a)
13:20:02 - 2020-06-25 13:20:02.129 -     #1 swift_slowAlloc <null> (libswiftCore.dylib:x86_64+0x2cd698)
13:20:02 - 2020-06-25 13:20:02.129 -     #2 ActorShell._spawn<A>(_:props:_:) ActorShell+Children.swift:342 (swift-distributed-actorsPackageTests:x86_64+0x4f615e)
13:20:02 - 2020-06-25 13:20:02.129 -     #3 ActorShell.spawn<A>(_:of:props:file:line:_:) ActorShell.swift:630 (swift-distributed-actorsPackageTests:x86_64+0x514aa0)
13:20:02 - 2020-06-25 13:20:02.129 -     #4 protocol witness for ActorRefFactory.spawn<A>(_:of:props:file:line:_:) in conformance ActorContext<A> <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x4ad0ef)
13:20:02 - 2020-06-25 13:20:02.129 -     #5 static Gossiper.spawn<A, B, C>(_:name:settings:props:makeLogic:) Gossiper.swift:40 (swift-distributed-actorsPackageTests:x86_64+0xa80262)
13:20:02 - 2020-06-25 13:20:02.129 -     #6 closure #1 in CRDT.Replicator.Shell.behavior.getter CRDT+ReplicatorShell.swift:74 (swift-distributed-actorsPackageTests:x86_64+0x5c7bb0)
13:20:02 - 2020-06-25 13:20:02.129 -     #7 partial apply for closure #1 in CRDT.Replicator.Shell.behavior.getter <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x5c7ea2)
13:20:02 - 2020-06-25 13:20:02.129 -     #8 start0 #1 <A>(_:depth:) in Behavior.start(context:) Behaviors.swift:762 (swift-distributed-actorsPackageTests:x86_64+0x572558)
13:20:02 - 2020-06-25 13:20:02.129 -     #9 Behavior.start(context:) Behaviors.swift:780 (swift-distributed-actorsPackageTests:x86_64+0x56ca16)
13:20:02 - 2020-06-25 13:20:02.129 -     #10 Supervisor.interpretSupervised0(target:context:processingAction:nFoldFailureDepth:) Supervision.swift:465 (swift-distributed-actorsPackageTests:x86_64+0xc9cfb5)
13:20:02 - 2020-06-25 13:20:02.129 -     #11 Supervisor.interpretSupervised0(target:context:processingAction:) Supervision.swift:457 (swift-distributed-actorsPackageTests:x86_64+0xc9a7c4)
13:20:02 - 2020-06-25 13:20:02.129 -     #12 Supervisor.startSupervised(target:context:) Supervision.swift:451 (swift-distributed-actorsPackageTests:x86_64+0xc9ca00)
13:20:02 - 2020-06-25 13:20:02.129 -     #13 ActorShell.interpretStart() ActorShell.swift:506 (swift-distributed-actorsPackageTests:x86_64+0x505af5)
13:20:02 - 2020-06-25 13:20:02.129 -     #14 ActorShell.interpretSystemMessage(message:) ActorShell.swift:306 (swift-distributed-actorsPackageTests:x86_64+0x503ff8)
13:20:02 - 2020-06-25 13:20:02.129 -     #15 Mailbox.mailboxRun(_:) Mailbox.swift:386 (swift-distributed-actorsPackageTests:x86_64+0xab445b)
13:20:02 - 2020-06-25 13:20:02.129 -     #16 Mailbox.run() Mailbox.swift:331 (swift-distributed-actorsPackageTests:x86_64+0xaac514)
13:20:02 - 2020-06-25 13:20:02.129 -     #17 partial apply for Mailbox.run() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xac19df)
13:20:02 - 2020-06-25 13:20:02.129 -     #18 thunk for @escaping @callee_guaranteed () -> () <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x55d267)
13:20:02 - 2020-06-25 13:20:02.129 -     #19 partial apply for thunk for @escaping @callee_guaranteed () -> () <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa32e0d)
13:20:02 - 2020-06-25 13:20:02.129 -     #20 thunk for @escaping @callee_guaranteed () -> (@out ()) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x55d827)
13:20:02 - 2020-06-25 13:20:02.129 -     #21 partial apply for thunk for @escaping @callee_guaranteed () -> (@out ()) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa330a5)
13:20:02 - 2020-06-25 13:20:02.129 -     #22 closure #1 in FixedThreadPool.init(_:) FixedThreadPool.swift:75 (swift-distributed-actorsPackageTests:x86_64+0xa32652)
13:20:02 - 2020-06-25 13:20:02.129 -     #23 partial apply for closure #1 in FixedThreadPool.init(_:) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xa32895)
13:20:02 - 2020-06-25 13:20:02.129 -     #24 closure #1 in Thread.init(_:) Thread.swift:53 (swift-distributed-actorsPackageTests:x86_64+0xcb649a)
13:20:02 - 2020-06-25 13:20:02.129 -     #25 partial apply for closure #1 in Thread.init(_:) <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xcb657d)
13:20:02 - 2020-06-25 13:20:02.129 -     #26 closure #1 in static Thread.runnerCallback.getter Thread.swift:132 (swift-distributed-actorsPackageTests:x86_64+0xcb7e3f)
13:20:02 - 2020-06-25 13:20:02.129 -     #27 @objc closure #1 in static Thread.runnerCallback.getter <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xcb7f10)
13:20:02 - 2020-06-25 13:20:02.129 -   Mutex M344895 (0x7b140041b820) created at:
13:20:02 - 2020-06-25 13:20:02.129 -     #0 pthread_mutex_init <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2baf3)
13:20:02 - 2020-06-25 13:20:02.129 -     #1 _Mutex.init() locks.swift:32 (swift-distributed-actorsPackageTests:x86_64+0xcd76a9)
13:20:02 - 2020-06-25 13:20:02.129 -     #2 _Mutex.__allocating_init() locks.swift (swift-distributed-actorsPackageTests:x86_64+0xcd7051)
13:20:02 - 2020-06-25 13:20:02.129 -     #3 Worker.init() FixedThreadPool.swift:24 (swift-distributed-actorsPackageTests:x86_64+0xa3166a)
13:20:02 - 2020-06-25 13:20:02.129 -     #4 Worker.__allocating_init() FixedThreadPool.swift (swift-distributed-actorsPackageTests:x86_64+0xa31531)
13:20:02 - 2020-06-25 13:20:02.129 -     #5 FixedThreadPool.init(_:) FixedThreadPool.swift:62 (swift-distributed-actorsPackageTests:x86_64+0xa31fd3)
13:20:02 - 2020-06-25 13:20:02.129 -     #6 FixedThreadPool.__allocating_init(_:) FixedThreadPool.swift (swift-distributed-actorsPackageTests:x86_64+0xa31a64)
13:20:02 - 2020-06-25 13:20:02.129 -     #7 ActorSystem.init(settings:) ActorSystem.swift:184 (swift-distributed-actorsPackageTests:x86_64+0x52b9ff)
13:20:02 - 2020-06-25 13:20:02.129 -     #8 ActorSystem.__allocating_init(settings:) ActorSystem.swift (swift-distributed-actorsPackageTests:x86_64+0x52a98c)
13:20:02 - 2020-06-25 13:20:02.129 -     #9 ActorSystem.__allocating_init(_:configuredWith:) ActorSystem.swift:150 (swift-distributed-actorsPackageTests:x86_64+0x52a650)
13:20:02 - 2020-06-25 13:20:02.129 -     #10 ClusteredActorSystemsXCTestCase.setUpNode(_:_:) ClusteredActorSystemsXCTestCase.swift:63 (swift-distributed-actorsPackageTests:x86_64+0xdedc37)
13:20:02 - 2020-06-25 13:20:02.129 -     #11 ActorSystemXCTestCase.setUpNode(_:_:) ActorSystemXCTestCase.swift:57 (swift-distributed-actorsPackageTests:x86_64+0xdd5188)
13:20:02 - 2020-06-25 13:20:02.129 -     #12 ActorSystemXCTestCase.setUp() ActorSystemXCTestCase.swift:47 (swift-distributed-actorsPackageTests:x86_64+0xdd4d46)
13:20:02 - 2020-06-25 13:20:02.129 -     #13 @objc ActorSystemXCTestCase.setUp() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xdd4eb4)
13:20:02 - 2020-06-25 13:20:02.129 -     #14 TraversalTests.setUp() TraversalTests.swift:29 (swift-distributed-actorsPackageTests:x86_64+0x15d756f)
13:20:02 - 2020-06-25 13:20:02.129 -     #15 @objc TraversalTests.setUp() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x15da224)
13:20:02 - 2020-06-25 13:20:02.129 -     #16 __48-[XCTestCase _performSetUpSequenceWithSelector:]_block_invoke_2 <null> (XCTest:x86_64+0x2f4fe)
13:20:02 - 2020-06-25 13:20:02.129 -   Thread T140 (tid=1641664, running) created by main thread at:
13:20:02 - 2020-06-25 13:20:02.129 -     #0 pthread_create <null> (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2aacd)
13:20:02 - 2020-06-25 13:20:02.129 -     #1 Thread.init(_:) Thread.swift:62 (swift-distributed-actorsPackageTests:x86_64+0xcb5df7)
13:20:02 - 2020-06-25 13:20:02.129 -     #2 Thread.__allocating_init(_:) Thread.swift (swift-distributed-actorsPackageTests:x86_64+0xcb58dc)
13:20:02 - 2020-06-25 13:20:02.129 -     #3 FixedThreadPool.init(_:) FixedThreadPool.swift:63 (swift-distributed-actorsPackageTests:x86_64+0xa320ca)
13:20:02 - 2020-06-25 13:20:02.129 -     #4 FixedThreadPool.__allocating_init(_:) FixedThreadPool.swift (swift-distributed-actorsPackageTests:x86_64+0xa31a64)
13:20:02 - 2020-06-25 13:20:02.129 -     #5 ActorSystem.init(settings:) ActorSystem.swift:184 (swift-distributed-actorsPackageTests:x86_64+0x52b9ff)
13:20:02 - 2020-06-25 13:20:02.130 -     #6 ActorSystem.__allocating_init(settings:) ActorSystem.swift (swift-distributed-actorsPackageTests:x86_64+0x52a98c)
13:20:02 - 2020-06-25 13:20:02.130 -     #7 ActorSystem.__allocating_init(_:configuredWith:) ActorSystem.swift:150 (swift-distributed-actorsPackageTests:x86_64+0x52a650)
13:20:02 - 2020-06-25 13:20:02.130 -     #8 ClusteredActorSystemsXCTestCase.setUpNode(_:_:) ClusteredActorSystemsXCTestCase.swift:63 (swift-distributed-actorsPackageTests:x86_64+0xdedc37)
13:20:02 - 2020-06-25 13:20:02.130 -     #9 ActorSystemXCTestCase.setUpNode(_:_:) ActorSystemXCTestCase.swift:57 (swift-distributed-actorsPackageTests:x86_64+0xdd5188)
13:20:02 - 2020-06-25 13:20:02.130 -     #10 ActorSystemXCTestCase.setUp() ActorSystemXCTestCase.swift:47 (swift-distributed-actorsPackageTests:x86_64+0xdd4d46)
13:20:02 - 2020-06-25 13:20:02.130 -     #11 @objc ActorSystemXCTestCase.setUp() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0xdd4eb4)
13:20:02 - 2020-06-25 13:20:02.130 -     #12 TraversalTests.setUp() TraversalTests.swift:29 (swift-distributed-actorsPackageTests:x86_64+0x15d756f)
13:20:02 - 2020-06-25 13:20:02.130 -     #13 @objc TraversalTests.setUp() <compiler-generated> (swift-distributed-actorsPackageTests:x86_64+0x15da224)
13:20:02 - 2020-06-25 13:20:02.130 -     #14 __48-[XCTestCase _performSetUpSequenceWithSelector:]_block_invoke_2 <null> (XCTest:x86_64+0x2f4fe)
13:20:02 - 2020-06-25 13:20:02.130 - SUMMARY: ThreadSanitizer: data race ActorShell.swift in ActorShell._myCell.getter
13:20:02 - 2020-06-25 13:20:02.130 - ==================

Metadata

Metadata

Assignees

No one assigned

    Labels

    2 - pick nextIf looking for work, pick this ticket :-)kind/bugFeature doesn't work as expected.t:actor

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions