[SPARK-11877] Prevent agg. fallback conf. from leaking across test suites #9857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The failing HiveCompatibilitySuite test, |
JoshRosen
changed the title
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2015
…ites This patch fixes an issue where the `spark.sql.TungstenAggregate.testFallbackStartsAt` SQLConf setting was not properly reset / cleared at the end of `TungstenAggregationQueryWithControlledFallbackSuite`. This ended up causing test failures in HiveCompatibilitySuite in Maven builds by causing spilling to occur way too frequently. This configuration leak was inadvertently introduced during test cleanup in #9618. Author: Josh Rosen <[email protected]> Closes #9857 from JoshRosen/clear-fallback-prop-in-test-teardown. (cherry picked from commit a66142d) Signed-off-by: Josh Rosen <[email protected]>
|
Test build #46402 has finished for PR 9857 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where the
spark.sql.TungstenAggregate.testFallbackStartsAtSQLConf setting was not properly reset / cleared at the end ofTungstenAggregationQueryWithControlledFallbackSuite. This ended up causing test failures in HiveCompatibilitySuite in Maven builds by causing spilling to occur way too frequently.This configuration leak was inadvertently introduced during test cleanup in #9618.