Skip to content

[SPARK-11644][SQL] Remove the option to turn off unsafe and codegen. #9618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-11644][SQL] Remove the option to turn off unsafe and codegen. #9618

wants to merge 4 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Nov 11, 2015

No description provided.

@rxin
Copy link
Contributor Author

rxin commented Nov 11, 2015

cc @yhuai @davies

davies
davies reviewed Nov 11, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala Outdated
Copy link
Contributor

@davies davies Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the comment

Copy link
Contributor Author

@rxin rxin Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@davies
Copy link
Contributor

davies commented Nov 11, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45597 has finished for PR 9618 at commit 95a9081.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class Metadata(\n * require(className == expectedClassName, s\"Error loading metadata: Expected class name\" +\n

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45604 has finished for PR 9618 at commit dd1fe92.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLBFGSExample\n * class LDA @Since(\"1.6.0\") (\n * case class Metadata(\n * require(className == expectedClassName, s\"Error loading metadata: Expected class name\" +\n

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2039 has finished for PR 9618 at commit dd1fe92.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Nov 11, 2015

These two tests need fix:

 org.apache.spark.sql.execution.metric.SQLMetricsSuite.Project metrics  42 ms   1
 org.apache.spark.sql.hive.execution.HiveExplainSuite.explain extended command

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45657 has finished for PR 9618 at commit b296915.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Nov 11, 2015
@rxin
[SPARK-11644][SQL] Remove the option to turn off unsafe and codegen.
c227180 
Author: Reynold Xin <[email protected]>

Closes #9618 from rxin/SPARK-11644.

(cherry picked from commit df97df2)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in df97df2 Nov 11, 2015
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
@rxin @dskrvk
[SPARK-11644][SQL] Remove the option to turn off unsafe and codegen.
265a4ae 
Author: Reynold Xin <[email protected]>

Closes apache#9618 from rxin/SPARK-11644.
@JoshRosen JoshRosen mentioned this pull request Nov 20, 2015
Closed
asfgit pushed a commit that referenced this pull request Nov 20, 2015
@JoshRosen
[SPARK-11877] Prevent agg. fallback conf. from leaking across test su…
eab90d3 
…ites

This patch fixes an issue where the `spark.sql.TungstenAggregate.testFallbackStartsAt` SQLConf setting was not properly reset / cleared at the end of `TungstenAggregationQueryWithControlledFallbackSuite`. This ended up causing test failures in HiveCompatibilitySuite in Maven builds by causing spilling to occur way too frequently.

This configuration leak was inadvertently introduced during test cleanup in #9618.

Author: Josh Rosen <[email protected]>

Closes #9857 from JoshRosen/clear-fallback-prop-in-test-teardown.

(cherry picked from commit a66142d)
Signed-off-by: Josh Rosen <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 20, 2015
@JoshRosen
[SPARK-11877] Prevent agg. fallback conf. from leaking across test su…
a66142d 
…ites

This patch fixes an issue where the `spark.sql.TungstenAggregate.testFallbackStartsAt` SQLConf setting was not properly reset / cleared at the end of `TungstenAggregationQueryWithControlledFallbackSuite`. This ended up causing test failures in HiveCompatibilitySuite in Maven builds by causing spilling to occur way too frequently.

This configuration leak was inadvertently introduced during test cleanup in #9618.

Author: Josh Rosen <[email protected]>

Closes #9857 from JoshRosen/clear-fallback-prop-in-test-teardown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @davies @SparkQA