Skip to content

Conversation

@felixcheung
Copy link
Member

Add support for for colnames, colnames<-, coltypes<-
Also added tests for names, names<- which have no test previously.

I merged with PR 8984 (coltypes). Clicked the wrong thing, crewed up the PR. Recreated it here. Was #9218

@shivaram @sun-rui

@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45719 has finished for PR 9654 at commit c102bc0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45825 has finished for PR 9654 at commit 21f36e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class JavaTrackStateDStream[KeyType, ValueType, StateType, EmittedType](\n

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45826 has finished for PR 9654 at commit 829893d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class StddevSamp(child: Expression,\n * case class StddevPop(\n * class TypedColumn[-T, U](\n * class JavaTrackStateDStream[KeyType, ValueType, StateType, EmittedType](\n

@felixcheung
Copy link
Member Author

any more comment?

R/pkg/R/types.R Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better name: rToSQLTypes

@SparkQA
Copy link

SparkQA commented Nov 20, 2015

Test build #46380 has finished for PR 9654 at commit f0419ac.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 20, 2015

Test build #46382 has finished for PR 9654 at commit 7e139f4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member Author

updated from comments.

@felixcheung
Copy link
Member Author

@sun-rui any more comment?

@felixcheung
Copy link
Member Author

@sun-rui ?

@sun-rui
Copy link
Contributor

sun-rui commented Nov 25, 2015

Will take a look soon

@felixcheung
Copy link
Member Author

Could we please review this? I think it would be great to get matching coltype<- in Spark 1.6

@SparkQA
Copy link

SparkQA commented Nov 27, 2015

Test build #46831 has finished for PR 9654 at commit e399acd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colnames<- also needs to be added to the exported list of functions ?

@shivaram
Copy link
Contributor

Couple of minor comments, but otherwise change looks good.

@SparkQA
Copy link

SparkQA commented Nov 29, 2015

Test build #46845 has finished for PR 9654 at commit d555cf8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

LGTM. Thanks @felixcheung

asfgit pushed a commit that referenced this pull request Nov 29, 2015
Add support for for colnames, colnames<-, coltypes<-
Also added tests for names, names<- which have no test previously.

I merged with PR 8984 (coltypes). Clicked the wrong thing, crewed up the PR. Recreated it here. Was #9218

shivaram sun-rui

Author: felixcheung <[email protected]>

Closes #9654 from felixcheung/colnamescoltypes.

(cherry picked from commit c793d2d)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in c793d2d Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants