-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9319][SPARKR] Add support for setting column names, types #9654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45719 has finished for PR 9654 at commit
|
c102bc0 to
21f36e0
Compare
|
Test build #45825 has finished for PR 9654 at commit
|
|
Test build #45826 has finished for PR 9654 at commit
|
|
any more comment? |
R/pkg/R/types.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better name: rToSQLTypes
829893d to
f0419ac
Compare
|
Test build #46380 has finished for PR 9654 at commit
|
|
Test build #46382 has finished for PR 9654 at commit
|
|
updated from comments. |
|
@sun-rui any more comment? |
|
@sun-rui ? |
|
Will take a look soon |
7e139f4 to
e399acd
Compare
|
Could we please review this? I think it would be great to get matching coltype<- in Spark 1.6 |
|
Test build #46831 has finished for PR 9654 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colnames<- also needs to be added to the exported list of functions ?
|
Couple of minor comments, but otherwise change looks good. |
|
Test build #46845 has finished for PR 9654 at commit
|
|
LGTM. Thanks @felixcheung |
Add support for for colnames, colnames<-, coltypes<- Also added tests for names, names<- which have no test previously. I merged with PR 8984 (coltypes). Clicked the wrong thing, crewed up the PR. Recreated it here. Was #9218 shivaram sun-rui Author: felixcheung <[email protected]> Closes #9654 from felixcheung/colnamescoltypes. (cherry picked from commit c793d2d) Signed-off-by: Shivaram Venkataraman <[email protected]>
Add support for for colnames, colnames<-, coltypes<-
Also added tests for names, names<- which have no test previously.
I merged with PR 8984 (coltypes). Clicked the wrong thing, crewed up the PR. Recreated it here. Was #9218
@shivaram @sun-rui