update from feedback, add tests

Author: felixcheung

R/pkg/NAMESPACE

@@ -28,6 +28,7 @@ exportMethods("arrange",
               "cache",
               "collect",
               "colnames",
+              "colnames<-",
               "coltypes",
               "coltypes<-",
               "columns",
@@ -58,6 +59,7 @@ exportMethods("arrange",
               "mutate",
               "na.omit",
               "names",
+              "names<-",
               "ncol",
               "nrow",
               "orderBy",

R/pkg/R/types.R

@@ -43,9 +43,9 @@ COMPLEX_TYPES <- list(
 DATA_TYPES <- as.environment(c(as.list(PRIMITIVE_TYPES), COMPLEX_TYPES))
 
 # An environment for mapping R to Scala, names are R types and values are Scala types.
-rToSQLTypes <- new.env()
-rToSQLTypes[["integer"]]   <- "integer" # in R, integer is 32bit
-rToSQLTypes[["numeric"]]   <- "double"  # in R, numeric == double which is 64bit
-rToSQLTypes[["double"]]    <- "double"
-rToSQLTypes[["character"]] <- "string"
-rToSQLTypes[["logical"]]   <- "boolean"
+rToSQLTypes <- as.environment(list(
+  "integer"   = "integer", # in R, integer is 32bit
+  "numeric"   = "double",  # in R, numeric == double which is 64bit
+  "double"    = "double",
+  "character" = "string",
+  "logical"   = "boolean"))

R/pkg/inst/tests/test_sparkSQL.R

@@ -630,11 +630,16 @@ test_that("names() colnames() set the column names", {
   colnames(df) <- c("col3", "col4")
   expect_equal(names(df)[1], "col3")
 
-  # Test base::colnames
+  # Test base::colnames base::names
   m2 <- cbind(1, 1:4)
   expect_equal(colnames(m2, do.NULL = FALSE), c("col1", "col2"))
   colnames(m2) <- c("x","Y")
   expect_equal(colnames(m2), c("x", "Y"))
+
+  z <- list(a = 1, b = "c", c = 1:3)
+  expect_equal(names(z)[3], "c")
+  names(z)[3] <- "c2"
+  expect_equal(names(z)[3], "c2")
 })
 
 test_that("head() and first() return the correct data", {