Skip to content

[SPARK-11417] [SQL] no @Override in codegen #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-11417] [SQL] no @Override in codegen #9372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...t/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ object GenerateOrdering extends CodeGenerator[Seq[SortOrder], Ordering[InternalR
${initMutableStates(ctx)}
}

@Override
public int compare(InternalRow a, InternalRow b) {
InternalRow ${ctx.INPUT_ROW} = null; // Holds current row being evaluated.
$comparisons
Expand Down
1 change: 0 additions & 1 deletion .../src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratePredicate.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ object GeneratePredicate extends CodeGenerator[Expression, (InternalRow) => Bool
${initMutableStates(ctx)}
}

@Override
public boolean eval(InternalRow ${ctx.INPUT_ROW}) {
${eval.code}
return !${eval.isNull} && ${eval.value};
Expand Down
7 changes: 0 additions & 7 deletions ...src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
if (cases.length > 0) {
val getter = "get" + ctx.primitiveTypeName(jt)
s"""
@Override
public $jt $getter(int i) {
if (isNullAt(i)) {
return ${ctx.defaultValue(jt)};
Expand All @@ -107,7 +106,6 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
if (cases.length > 0) {
val setter = "set" + ctx.primitiveTypeName(jt)
s"""
@Override
public void $setter(int i, $jt value) {
nullBits[i] = false;
switch (i) {
Expand Down Expand Up @@ -169,7 +167,6 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
${initMutableStates(ctx)}
}

@Override
public Object apply(Object r) {
// GenerateProjection does not work with UnsafeRows.
assert(!(r instanceof ${classOf[UnsafeRow].getName}));
Expand All @@ -189,7 +186,6 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
public void setNullAt(int i) { nullBits[i] = true; }
public boolean isNullAt(int i) { return nullBits[i]; }

@Override
public Object genericGet(int i) {
if (isNullAt(i)) return null;
switch (i) {
Expand All @@ -210,14 +206,12 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
$specificAccessorFunctions
$specificMutatorFunctions

@Override
public int hashCode() {
int result = 37;
$hashUpdates
return result;
}

@Override
public boolean equals(Object other) {
if (other instanceof SpecificRow) {
SpecificRow row = (SpecificRow) other;
Expand All @@ -227,7 +221,6 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
return super.equals(other);
}

@Override
public InternalRow copy() {
Object[] arr = new Object[${expressions.length}];
${copyColumns}
Expand Down