[SPARK-11417] [SQL] no @Override in codegen #9372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @rxin |
|
Test build #44660 has finished for PR 9372 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Oct 30, 2015
Older version of Janino (>2.7) does not support Override, we should not use that in codegen. Author: Davies Liu <[email protected]> Closes #9372 from davies/no_override. (cherry picked from commit eb59b94) Signed-off-by: Davies Liu <[email protected]> Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratePredicate.scala
Contributor
|
Why is this bug not exposed before? |
Contributor
Author
|
The packaged one is fine, only hit this if you run with older version of Janino. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older version of Janino (>2.7) does not support @OverRide, we should not use that in codegen.