Skip to content

[SPARK-11388][Build]Fix self closing tags. #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-11388][Build]Fix self closing tags. #9339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* A handle to a running Spark application.
* <p/>
* <p>
Copy link
Member

@srowen srowen Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove this entirely. Now, the tag isn't closed. The newline isn't important here anyhow. Feel free to clean up any other javadoc warnings you encounter.

Copy link
Contributor

@vanzin vanzin Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc enforces a broken version of HTML where you don't need to close certain tags like p. It's a little annoying, but you still need the HTML to format the docs nicely.

* Provides runtime information about the underlying Spark application, and actions to control it.
*
* @since 1.6.0
Expand Down Expand Up @@ -110,7 +110,7 @@ public interface Listener {
* Callback for changes in the handle's state.
*
* @param handle The updated handle.
* @see {@link SparkAppHandle#getState()}
* @see SparkAppHandle#getState()
*/
void stateChanged(SparkAppHandle handle);

Expand Down
8 changes: 4 additions & 4 deletions launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ public SparkLauncher setVerbose(boolean verbose) {

/**
* Launches a sub-process that will start the configured Spark application.
* <p/>
* <p>
* The {@link #startApplication(SparkAppHandle.Listener...)} method is preferred when launching
* Spark, since it provides better control of the child application.
*
Expand All @@ -362,16 +362,16 @@ public Process launch() throws IOException {

/**
* Starts a Spark application.
* <p/>
* <p>
* This method returns a handle that provides information about the running application and can
* be used to do basic interaction with it.
* <p/>
* <p>
* The returned handle assumes that the application will instantiate a single SparkContext
* during its lifetime. Once that context reports a final state (one that indicates the
* SparkContext has stopped), the handle will not perform new state transitions, so anything
* that happens after that cannot be monitored. If the underlying application is launched as
* a child process, {@link SparkAppHandle#kill()} can still be used to kill the child process.
* <p/>
* <p>
* Currently, all applications are launched as child processes. The child's stdout and stderr
* are merged and written to a logger (see <code>java.util.logging</code>). The logger's name
* can be defined by setting {@link #CHILD_PROCESS_LOGGER_NAME} in the app's configuration. If
Expand Down