Skip to content

Conversation

@hvanhovell
Copy link
Contributor

Java 8 javadoc does not like self closing tags: <p/>, <br/>, ...

This PR fixes those.

@vanzin
Copy link
Contributor

vanzin commented Oct 29, 2015

I thought we disabled doclint in java 8, but apparently we just disable one check... :-/

ok to test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove this entirely. Now, the tag isn't closed. The newline isn't important here anyhow. Feel free to clean up any other javadoc warnings you encounter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc enforces a broken version of HTML where you don't need to close certain tags like p. It's a little annoying, but you still need the HTML to format the docs nicely.

@vanzin
Copy link
Contributor

vanzin commented Oct 29, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Oct 29, 2015

Test build #44581 has finished for PR 9339 at commit 7d80528.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor Author

Hmmm, test fails with the following beautiful error:

[error] (core/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 4809 s, completed Oct 29, 2015 2:32:35 AM

Retesting.

@hvanhovell
Copy link
Contributor Author

jenkins retest this please

@vanzin
Copy link
Contributor

vanzin commented Oct 29, 2015

probably unrelated. this change shouldn't really cause any test failures. retest this please

@SparkQA
Copy link

SparkQA commented Oct 29, 2015

Test build #44588 has finished for PR 9339 at commit 7d80528.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Oct 29, 2015

That's a known flaky pyspark test. Change LGTM.

@asfgit asfgit closed this in 3bb2a8d Oct 29, 2015
@srowen
Copy link
Member

srowen commented Oct 29, 2015

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants