-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-11388][Build]Fix self closing tags. #9339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I thought we disabled doclint in java 8, but apparently we just disable one check... :-/ ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove this entirely. Now, the tag isn't closed. The newline isn't important here anyhow. Feel free to clean up any other javadoc warnings you encounter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadoc enforces a broken version of HTML where you don't need to close certain tags like p. It's a little annoying, but you still need the HTML to format the docs nicely.
|
ok to test |
|
Test build #44581 has finished for PR 9339 at commit
|
|
Hmmm, test fails with the following beautiful error: Retesting. |
|
jenkins retest this please |
|
probably unrelated. this change shouldn't really cause any test failures. retest this please |
|
Test build #44588 has finished for PR 9339 at commit
|
|
That's a known flaky pyspark test. Change LGTM. |
|
merged to master |
Java 8 javadoc does not like self closing tags:
<p/>,<br/>, ...This PR fixes those.