-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-11210][SPARKR] Add window functions into SparkR [step 2]. #9196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #44055 has finished for PR 9196 at commit
|
|
This is merging 2 PR/JIRA? |
|
@felixcheung , this is a WIP as a successive step based on the previous PR for SPARK-11209 which has not been merged. After the PR for SPARK-11209 is merged, I will rebase this PR to master branch. |
|
Jenkins, retest this please |
|
Test build #44122 has finished for PR 9196 at commit
|
|
Rebased to master |
|
Test build #44404 has finished for PR 9196 at commit
|
|
looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rank seems like a more common r function. Are there any alternate ideas for names here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since base::rank() has a different signature with this rank(), it is possible to expose both of them under the same name rank().
|
Test build #44523 has finished for PR 9196 at commit
|
|
LGTM. Merging this. Thanks @sun-rui |
No description provided.