Skip to content

Commit b52a98d

Browse files
author
Sun Rui
committed
Expose base::rank().
1 parent 2e84e2d commit b52a98d

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

R/pkg/R/functions.R

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2179,6 +2179,13 @@ setMethod("rank",
21792179
column(jc)
21802180
})
21812181

2182+
# Expose rank() in the R base package
2183+
setMethod("rank",
2184+
signature(x = "ANY"),
2185+
function(x, ...) {
2186+
base::rank(x, ...)
2187+
})
2188+
21822189
#' rowNumber
21832190
#'
21842191
#' Window function: returns a sequential number starting at 1 within a window partition.

R/pkg/R/generics.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ setGeneric("randn", function(seed) { standardGeneric("randn") })
904904

905905
#' @rdname rank
906906
#' @export
907-
setGeneric("rank", function(x) { standardGeneric("rank") })
907+
setGeneric("rank", function(x, ...) { standardGeneric("rank") })
908908

909909
#' @rdname regexp_extract
910910
#' @export

R/pkg/inst/tests/test_sparkSQL.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -833,6 +833,10 @@ test_that("column functions", {
833833
c13 <- cumeDist() + ntile(1)
834834
c14 <- denseRank() + percentRank() + rank() + rowNumber()
835835

836+
# Test if base::rank() is exposed
837+
expect_equal(class(rank())[[1]], "Column")
838+
expect_equal(rank(1:3), as.numeric(c(1:3)))
839+
836840
df <- jsonFile(sqlContext, jsonPath)
837841
df2 <- select(df, between(df$age, c(20, 30)), between(df$age, c(10, 20)))
838842
expect_equal(collect(df2)[[2, 1]], TRUE)

0 commit comments

Comments
 (0)