[SPARK-10491] [MLlib] move RowMatrix.dspr to BLAS #8663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Since the JIRA references the reason for moving this being sharing code with some other components, maybe it would be good to have those other components also the method? |
|
Test build #42181 has finished for PR 8663 at commit
|
Contributor
There was a problem hiding this comment.
- Should be
sprinstead ofdspr. We only use double precision. - It might be useful to make
UaDenseVector(or add a convenient method) for API consistency. - Do you mind adding tests for both dense and sparse input?
Contributor
Contributor
Contributor
Author
|
@mengxr Sorry for the delay. working on it now. |
Contributor
Author
|
@mengxr Thanks for the review. Updated. |
Contributor
|
LGTM pending Jenkins |
|
Test build #42491 has finished for PR 8663 at commit
|
Contributor
|
Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/SPARK-10491
We implemented dspr with sparse vector support in
RowMatrix. This method is also used in WeightedLeastSquares and other places. It would be useful to move it tolinalg.BLAS.Let me know if new UT needed.