-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-9834][MLLIB] implement weighted least squares via normal equation #8588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #41977 has finished for PR 8588 at commit
|
|
Test build #41979 has finished for PR 8588 at commit
|
|
Test build #41994 has finished for PR 8588 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need standardizeLabel? I think without regularization, with/without standardization will not change the solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need it but I think it is useful to list the values explicitly here.
|
LGTM, did not check low level implementation |
|
jenkins test this please |
|
Test build #42145 has finished for PR 8588 at commit
|
|
Merged into master. I will make follow-up PRs to do the refactoring. |
The goal of this PR is to have a weighted least squares implementation that takes the normal equation approach, and hence to be able to provide R-like summary statistics and support IRLS (used by GLMs). The tests match R's lm and glmnet.
There are couple TODOs that can be addressed in future PRs:
dsprtoBLASIt would be nice to have this merged first because it blocks couple other features.
@dbtsai