Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Sep 3, 2015

The goal of this PR is to have a weighted least squares implementation that takes the normal equation approach, and hence to be able to provide R-like summary statistics and support IRLS (used by GLMs). The tests match R's lm and glmnet.

There are couple TODOs that can be addressed in future PRs:

  • consolidate summary statistics aggregators
  • move dspr to BLAS
  • etc

It would be nice to have this merged first because it blocks couple other features.

@dbtsai

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #41977 has finished for PR 8588 at commit 34107aa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Instance(w: Double, a: Vector, b: Double)

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #41979 has finished for PR 8588 at commit c75ff92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Instance(w: Double, a: Vector, b: Double)

@mengxr mengxr changed the title [WIP][SPARK-9834][MLLIB] implement weighted least squares via normal equation [SPARK-9834][MLLIB] implement weighted least squares via normal equation Sep 4, 2015
@SparkQA
Copy link

SparkQA commented Sep 4, 2015

Test build #41994 has finished for PR 8588 at commit 1614f22.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Instance(w: Double, a: Vector, b: Double)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need standardizeLabel? I think without regularization, with/without standardization will not change the solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it but I think it is useful to list the values explicitly here.

@feynmanliang
Copy link
Contributor

LGTM, did not check low level implementation

@feynmanliang
Copy link
Contributor

jenkins test this please

@SparkQA
Copy link

SparkQA commented Sep 8, 2015

Test build #42145 has finished for PR 8588 at commit c2ec746.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Instance(w: Double, a: Vector, b: Double)

@mengxr
Copy link
Contributor Author

mengxr commented Sep 9, 2015

Merged into master. I will make follow-up PRs to do the refactoring.

@asfgit asfgit closed this in 52fe32f Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants