Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Sep 2, 2015

New screenshots after this fix:

s1

Default:
s2

After clicking +details:
s3

@zsxwing
Copy link
Member Author

zsxwing commented Sep 2, 2015

cc @andrewor14

@zsxwing zsxwing changed the title Move visualization above explain output and hide explain by default [SPARK-10411][SQL]Move visualization above explain output and hide explain by default Sep 2, 2015
@SparkQA
Copy link

SparkQA commented Sep 2, 2015

Test build #41927 has finished for PR 8570 at commit 2e3d4b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

pwendell commented Sep 2, 2015

For the details link - can you use the standard drop down icon we use in other places?

@andrewor14
Copy link
Contributor

@pwendell do you mean the triangle, e.g. > Event timeline

@pwendell
Copy link
Contributor

pwendell commented Sep 2, 2015

Yes - I mean the triangle image used there and in a few other places (such as showing more metrics).

@zsxwing
Copy link
Member Author

zsxwing commented Sep 3, 2015

Fixed it. These are the new screenshots.

s4

s5

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #41957 has finished for PR 8570 at commit 9978206.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

LGTM merging into master 1.5 thanks!

asfgit pushed a commit that referenced this pull request Sep 3, 2015
…explain by default

New screenshots after this fix:

<img width="627" alt="s1" src="https://cloud.githubusercontent.com/assets/1000778/9625782/4b2dba36-518b-11e5-9104-c713ff026e3d.png">

Default:
<img width="462" alt="s2" src="https://cloud.githubusercontent.com/assets/1000778/9625817/92366e50-518b-11e5-9981-cdfb774d66b8.png">

After clicking `+details`:
<img width="377" alt="s3" src="https://cloud.githubusercontent.com/assets/1000778/9625784/4ba24342-518b-11e5-8522-846a16a95d44.png">

Author: zsxwing <[email protected]>

Closes #8570 from zsxwing/SPARK-10411.

(cherry picked from commit 0349b5b)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 0349b5b Sep 3, 2015
@zsxwing zsxwing deleted the SPARK-10411 branch September 3, 2015 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants