Skip to content

[SPARK-10411][SQL]Move visualization above explain output and hide explain by default #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-10411][SQL]Move visualization above explain output and hide explain by default #8570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e3d4b9
Move visualization above explain output and hide explain by default
zsxwing Sep 2, 2015
9978206
Use the standard drop down icon for the details link
zsxwing Sep 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,14 @@ private[sql] class ExecutionPage(parent: SQLTab) extends WebUIPage("execution")
}}
</li>
}}
<li>
<strong>Detail: </strong><br/>
<pre>{executionUIData.physicalPlanDescription}</pre>
</li>
</ul>
</div>

val metrics = listener.getExecutionMetrics(executionId)

summary ++ planVisualization(metrics, executionUIData.physicalPlanGraph)
summary ++
planVisualization(metrics, executionUIData.physicalPlanGraph) ++
physicalPlanDescription(executionUIData.physicalPlanDescription)
}.getOrElse {
<div>No information to display for Plan {executionId}</div>
}
Expand Down Expand Up @@ -124,4 +122,23 @@ private[sql] class ExecutionPage(parent: SQLTab) extends WebUIPage("execution")

private def jobURL(jobId: Long): String =
"%s/jobs/job?id=%s".format(UIUtils.prependBaseUri(parent.basePath), jobId)

private def physicalPlanDescription(physicalPlanDescription: String): Seq[Node] = {
<div>
<span style="cursor: pointer;" onclick="clickPhysicalPlanDetails();">
<span id="physical-plan-details-arrow" class="arrow-closed"></span>
<a>Details</a>
</span>
</div>
<div id="physical-plan-details" style="display: none;">
<pre>{physicalPlanDescription}</pre>
</div>
<script>
function clickPhysicalPlanDetails() {{
$('#physical-plan-details').toggle();
$('#physical-plan-details-arrow').toggleClass('arrow-open').toggleClass('arrow-closed');
}}
</script>
<br/>
}
}