Skip to content

[SPARK-10059] [yarn] Explicitly add JSP dependencies for tests. #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-10059] [yarn] Explicitly add JSP dependencies for tests. #8251

wants to merge 1 commit into from

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Aug 17, 2015

No description provided.

srowen
srowen reviewed Aug 17, 2015
View reviewed changes
yarn/pom.xml
Copy link
Member

@srowen srowen Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be synced with the servlet API version? Ideally I suppose it does but I don't know how hard that is to plumb. I thought we had servlet 3.x in the build but you have probably looked more recently. I know JSTL is versioned differently.

Copy link
Contributor Author

@vanzin vanzin Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with that assumption, but these are actually the newest versions of those two artifacts.

Copy link
Contributor Author

@vanzin vanzin Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22javax.servlet.jsp.jstl%22

Copy link
Member

@srowen srowen Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I remember. JSP is also versioned separately such that 2.2 is part of Servlet 3.0. Carry on. http://tomcat.apache.org/whichversion.html

@SparkQA
Copy link

SparkQA commented Aug 17, 2015

Test build #41051 has finished for PR 8251 at commit 88af716.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 17, 2015

retest this please

@vanzin
Copy link
Contributor Author

vanzin commented Aug 17, 2015

The pyspark/yarn failure in the last run is a regression I introduced recently; I opened #8258 to fix it.

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41068 timed out for PR 8251 at commit 88af716 after a configured wait of 175m.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 18, 2015

YarnClusterSuite passed, so I'll merge this so that other PRs get past this point.

asfgit pushed a commit that referenced this pull request Aug 18, 2015
[SPARK-10059] [YARN] Explicitly add JSP dependencies for tests.
bfb4c84 
Author: Marcelo Vanzin <[email protected]>

Closes #8251 from vanzin/SPARK-10059.

(cherry picked from commit ee093c8)
Signed-off-by: Marcelo Vanzin <[email protected]>
@asfgit asfgit closed this in ee093c8 Aug 18, 2015
@vanzin vanzin deleted the SPARK-10059 branch August 18, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanzin @SparkQA @srowen