Skip to content

[SPARK-10059] [yarn] Explicitly add JSP dependencies for tests. #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-10059] [yarn] Explicitly add JSP dependencies for tests. #8251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions yarn/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,28 @@
<artifactId>jetty-servlet</artifactId>
</dependency>
<!-- End of shaded deps. -->


<!--
SPARK-10059: Explicitly add JSP dependencies for tests since the MiniYARN cluster needs them.
-->
<dependency>
<groupId>org.eclipse.jetty.orbit</groupId>
<artifactId>javax.servlet.jsp</artifactId>
<version>2.2.0.v201112011158</version>
Copy link
Member

@srowen srowen Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be synced with the servlet API version? Ideally I suppose it does but I don't know how hard that is to plumb. I thought we had servlet 3.x in the build but you have probably looked more recently. I know JSTL is versioned differently.

Copy link
Contributor Author

@vanzin vanzin Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with that assumption, but these are actually the newest versions of those two artifacts.

Copy link
Contributor Author

@vanzin vanzin Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22javax.servlet.jsp.jstl%22

Copy link
Member

@srowen srowen Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I remember. JSP is also versioned separately such that 2.2 is part of Servlet 3.0. Carry on. http://tomcat.apache.org/whichversion.html

<scope>test</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.orbit</groupId>
<artifactId>javax.servlet.jsp.jstl</artifactId>
<version>1.2.0.v201105211821</version>
<scope>test</scope>
</dependency>

<!--
See SPARK-3710. hadoop-yarn-server-tests in Hadoop 2.2 fails to pull some needed
dependencies, so they need to be added manually for the tests to work.
-->

<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-yarn-server-tests</artifactId>
Expand Down Expand Up @@ -137,7 +153,7 @@
<scope>test</scope>
</dependency>
</dependencies>

<build>
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
Expand Down