[HOTFIX] fix flaky test in PySpark SQL #7344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #1040 has finished for PR 7344 at commit
|
davies
pushed a commit
that referenced
this pull request
Jul 10, 2015
It may loss precision in microseconds when using float for it. Author: Davies Liu <[email protected]> Closes #7344 from davies/fix_date_test and squashes the following commits: 249ec61 [Davies Liu] fix flaky test
Contributor
There was a problem hiding this comment.
can you add an inline comment explaining what's happening here?
Contributor
There was a problem hiding this comment.
(and just merge it after adding the comment)
Contributor
Author
|
It was merged already. |
Contributor
|
OK can you push a commit directly to master to add inline comment? |
Contributor
Author
|
Added. b6fc0ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may loss precision in microseconds when using float for it.