Skip to content

Conversation

@harishreedharan
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35484 has finished for PR 6939 at commit 94b80ae.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 23, 2015

This is probably fine, but are there any potential incompatibilities or significant differences between the two that would affect any users? might be worth a scan through the release notes and/or resolved JIRAs as a sanity check.

@srowen
Copy link
Member

srowen commented Jun 30, 2015

Ping @harishreedharan I am sure you wouldn't propose this otherwise, but, just wanted to understand what if any potential incompatibilities this entails, particularly regarding dependencies. Do you know of any risks?

@harishreedharan
Copy link
Contributor Author

I am on vacation till Sunday. Please feel free to merge this - if I have
any concerns at that time I will make some noise.

On Tuesday, June 30, 2015, Sean Owen [email protected] wrote:

Ping @harishreedharan https://github.com/harishreedharan I am sure you
wouldn't propose this otherwise, but, just wanted to understand what if any
potential incompatibilities this entails, particularly regarding
dependencies. Do you know of any risks?


Reply to this email directly or view it on GitHub
#6939 (comment).

Thanks,
Hari

@tdas
Copy link
Contributor

tdas commented Jul 1, 2015

I will wait for the #6830 to be merged which is more contentious. Some things may need to be updated in this PR if there are conflicts. And then we will be able to run flume scala, java and python tests against 1.6.0 to see if there are potential issues.

@harishreedharan
Copy link
Contributor Author

ping @tdas

@tdas
Copy link
Contributor

tdas commented Jul 10, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 10, 2015

Test build #36990 has finished for PR 6939 at commit 94b80ae.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@harishreedharan
Copy link
Contributor Author

This pyspark test has been failing all over:

======================================================================
FAIL: test_time_with_timezone (__main__.SQLTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 716, in test_time_with_timezone
    self.assertEqual(now, now1)
AssertionError: datetime.datetime(2015, 7, 9, 20, 56, 12, 108430) != datetime.datetime(2015, 7, 9, 20, 56, 12, 108429)

@marmbrus - In case you are not aware.

@davies
Copy link
Contributor

davies commented Jul 10, 2015

@harishreedharan Will fix the flaky test by #7344

@SparkQA
Copy link

SparkQA commented Jul 12, 2015

Test build #1043 has finished for PR 6939 at commit 94b80ae.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 12, 2015

Test build #1044 has finished for PR 6939 at commit 94b80ae.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 13, 2015

Test build #1045 has finished for PR 6939 at commit 94b80ae.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 13, 2015

Since #6830 is merged and this passes, anyone object to merging?

@tdas
Copy link
Contributor

tdas commented Jul 13, 2015

LGTM, since all scala/java/python tests pass, this is good to go. I am merging this to master.

harishreedharan added a commit that referenced this pull request Jul 13, 2015
Author: Hari Shreedharan <[email protected]>

Closes #6939 from harishreedharan/upgrade-flume-1.6.0 and squashes the following commits:

94b80ae [Hari Shreedharan] [SPARK-8533][Streaming] Upgrade Flume to 1.6.0
@tdas
Copy link
Contributor

tdas commented Jul 13, 2015

Hey @harishreedharan i have merged this. Somehow this PR was not closed automatically. Can you close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants