Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Jun 22, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35418 has finished for PR 6927 at commit 3bb9ee1.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35419 has finished for PR 6927 at commit 319bd3f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35421 has finished for PR 6927 at commit f34971c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line.

@dbtsai
Copy link
Member

dbtsai commented Jun 22, 2015

LGTM except minor issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long. Or just import shared._

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35526 has finished for PR 6927 at commit ae5baa8.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra line.

@dbtsai
Copy link
Member

dbtsai commented Jun 23, 2015

Although LeastSquaresAggregator and LeastSquaresCostFun are private, MiMa is not happy about the changes.

[error]  * method this(org.apache.spark.mllib.linalg.Vector,Double,Double,Array[Double],Array[Double])Unit in class org.apache.spark.ml.regression.LeastSquaresAggregator does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.ml.regression.LeastSquaresAggregator.this")
[error]  * method this(org.apache.spark.rdd.RDD,Double,Double,Array[Double],Array[Double],Double)Unit in class org.apache.spark.ml.regression.LeastSquaresCostFun does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.ml.regression.LeastSquaresCostFun.this")

Please exclude them. Thanks.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35530 has finished for PR 6927 at commit 4016fac.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35534 has finished for PR 6927 at commit 0ad384c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Jun 23, 2015

Thanks. Merged into master.

@asfgit asfgit closed this in 2b1111d Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants