Skip to content

[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem #6731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9610b08
Converted actorSystem to function and added deprecated flag
Jun 9, 2015
9ed89e7
Added a version info for deprecation
Jun 9, 2015
be43817
Restored to val
Jun 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/org/apache/spark/SparkEnv.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ package org.apache.spark
import java.io.File
import java.net.Socket

import akka.actor.ActorSystem

import scala.collection.JavaConversions._
import scala.collection.mutable
import scala.util.Properties
Expand Down Expand Up @@ -75,7 +77,8 @@ class SparkEnv (
val conf: SparkConf) extends Logging {

// TODO Remove actorSystem
val actorSystem = rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem
@deprecated("Actor system is no longer supported as of 1.4")
Copy link
Contributor

@rxin rxin Jun 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the idiom for scala deprecation is

@deprecated("Actor system in SparkEnv is no longer supported", "1.4.0")

val actorSystem: ActorSystem = rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem

private[spark] var isStopped = false
private val pythonWorkers = mutable.HashMap[(String, Map[String, String]), PythonWorkerFactory]()
Expand Down