Skip to content

[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem #6731

wants to merge 3 commits into from

Conversation

@ilganeli
Copy link

@ilganeli ilganeli commented Jun 9, 2015

Changed SparkEnv.actorSystem to be a function such that we can use the deprecated flag with it and added a deprecated message.

rxin
rxin reviewed Jun 9, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/SparkEnv.scala Outdated
Copy link
Contributor

@rxin rxin Jun 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a version?

@SparkQA
Copy link

SparkQA commented Jun 9, 2015

Test build #34537 has finished for PR 6731 at commit 9610b08.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 10, 2015

Test build #34538 has finished for PR 6731 at commit 9ed89e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Jun 10, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/SparkEnv.scala
Copy link
Contributor

@rxin rxin Jun 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the idiom for scala deprecation is

@deprecated("Actor system in SparkEnv is no longer supported", "1.4.0")

@zsxwing
Copy link
Member

zsxwing commented Jun 10, 2015

Changed SparkEnv.actorSystem to be a function such that we can use the deprecated flag with it and added a deprecated message.

I can add @deprecated flat to a val. See
screen shot 2015-06-10 at 9 10 23 pm

@SparkQA
Copy link

SparkQA commented Jun 10, 2015

Test build #34614 has finished for PR 6731 at commit be43817.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jun 10, 2015

Thanks - merging this in.

@asfgit asfgit closed this in 2b550a5 Jun 10, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem
bb44816 
Changed ```SparkEnv.actorSystem``` to be a function such that we can use the deprecated flag with it and added a deprecated message.

Author: Ilya Ganelin <[email protected]>

Closes apache#6731 from ilganeli/SPARK-7996 and squashes the following commits:

be43817 [Ilya Ganelin] Restored to val
9ed89e7 [Ilya Ganelin] Added a version info for deprecation
9610b08 [Ilya Ganelin] Converted actorSystem to function and added deprecated flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilganeli @SparkQA @zsxwing @rxin