Skip to content

Handle the vals that never used #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Handle the vals that never used #565

wants to merge 2 commits into from

Conversation

@WangTaoTheTonic
Copy link
Contributor

@WangTaoTheTonic WangTaoTheTonic commented Apr 26, 2014

In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt".
Delete vals that never used in other files.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 26, 2014

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Apr 26, 2014

I think this is a good change. It's pretty easy to run inspections over whole modules or the whole project to catch dead stores. I wonder if that's better than reviewing piecemeal changes?

@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented Apr 26, 2014

Hi Owen, thanks for your suggestion.
I inspected the unused assignment, method parameters and symbol using Intellij IDEA, here is the results exclude test resources.
Please review.

@srowen
Copy link
Member

srowen commented Apr 26, 2014

Just my $0.02 here -- I think the "teenager" variables, while not used, are there as illustrative examples and should likely be left in. The "host" variable likewise might useful just for completeness. I agree with the other changes you found.

@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented Apr 26, 2014

Thanks for that, i already fixed it.

pwendell
pwendell reviewed Apr 27, 2014
View reviewed changes
examples/src/main/java/org/apache/spark/examples/sql/JavaSparkSQL.java Outdated
Copy link
Contributor

@pwendell pwendell Apr 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this get deleted? This is an example for expository purposes

@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented Apr 27, 2014

You two guys differ about this, so what are we gonna do?

@rxin
Copy link
Contributor

rxin commented Apr 28, 2014

I don't think it is a big deal in this case. It could go either way so we probably shouldn't spend time arguing about this.

@rxin
Copy link
Contributor

rxin commented Apr 28, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 28, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 28, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 28, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 28, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14540/

@rxin
Copy link
Contributor

rxin commented Apr 30, 2014

Thanks. I've merged this.

asfgit pushed a commit that referenced this pull request Apr 30, 2014
@WangTaoTheTonic @rxin
Handle the vals that never used
b0ded1f 
In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt".
Delete vals that never used in other files.

Author: WangTao <[email protected]>

Closes #565 from WangTaoTheTonic/master and squashes the following commits:

17cacfc [WangTao] Handle the unused assignment, method parameters and symbol inspected by Intellij IDEA
37b4090 [WangTao] Handle the vals that never used

(cherry picked from commit 7025dda)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 7025dda Apr 30, 2014
pwendell added a commit to pwendell/spark that referenced this pull request May 12, 2014
@pwendell @rxin
Merge pull request apache#565 from pwendell/dev-scripts. Closes apach…
f892da8 
…e#565.

SPARK-1066: Add developer scripts to repository.

These are some developer scripts I've been maintaining in a separate public repo. This patch adds them to the Spark repository so they can evolve here and are clearly accessible to all committers.

I may do some small additional clean-up in this PR, but wanted to put them here in case others want to review. There are a few types of scripts here:

1. A tool to merge pull requests.
2. A script for packaging releases.
3. A script for auditing release candidates.

Author: Patrick Wendell <[email protected]>

== Merge branch commits ==

commit 5d5d331d01f6fd59c2eb830f652955119b012173
Author: Patrick Wendell <[email protected]>
Date:   Sat Feb 8 22:11:47 2014 -0800

    SPARK-1066: Add developer scripts to repository.
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@WangTaoTheTonic @pdeyhim
Handle the vals that never used
4cecff2 
In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt".
Delete vals that never used in other files.

Author: WangTao <[email protected]>

Closes apache#565 from WangTaoTheTonic/master and squashes the following commits:

17cacfc [WangTao] Handle the unused assignment, method parameters and symbol inspected by Intellij IDEA
37b4090 [WangTao] Handle the vals that never used
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
@huangtianhua @bzhaoopenstack
Fix syntax error: unexpected end of file (apache#565)
8cffb1d
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 16, 2022
@leejaywei
Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)
197dc34 
This reverts commit 4da04fc5,
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Feb 24, 2023
@leejaywei
Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2"" (apach…
755d006 
…e#591)

* Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)"

This reverts commit 197dc34.

* Revert "minor fix ut"

This reverts commit 6ef82b4.
@bjornjorgensen bjornjorgensen mentioned this pull request Mar 12, 2023
Closed
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 8, 2023
@leejaywei @zheniantoushipashi
Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)
fb748c5 
This reverts commit 4da04fc5,
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 8, 2023
@leejaywei @zheniantoushipashi
Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2"" (apach…
ff8933c 
…e#591)

* Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)"

This reverts commit 197dc34.

* Revert "minor fix ut"

This reverts commit 6ef82b4.
turboFei pushed a commit to turboFei/spark that referenced this pull request Nov 6, 2025
@wangyum
[HADP-55107] Commit all partitions if contains selective filter in ex…
5df24d6 
…ecuteTake (apache#565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WangTaoTheTonic @AmplabJenkins @srowen @rxin @pwendell