Skip to content

Conversation

@liancheng
Copy link
Contributor

This is a follow-up of #5279 and #5398. ScalaReflection.convertRowToScala is on a critical path, but was implemented in a rather inefficient way.

Review on Reviewable

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29856 has started for PR 5419 at commit d698d03.

@SparkQA
Copy link

SparkQA commented Apr 8, 2015

Test build #29856 has finished for PR 5419 at commit d698d03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29856/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind reverting this to avoid conflicting with #5279?

@liancheng
Copy link
Contributor Author

Actually the convertRowToScala part is already handled in #5279, and the lazy val schema part is handled in #5398, so I'm closing this.

@liancheng liancheng closed this Apr 9, 2015
@liancheng liancheng deleted the faster-row-conversion branch April 9, 2015 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants