[SPARK-6748] [SQL] Makes QueryPlan.schema a lazy val #5398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.collect()callsSparkPlan.executeCollect(), which consists of a single line:execute().map(ScalaReflection.convertRowToScala(_, schema)).collect()The problem is that,
QueryPlan.schemais a function. And since 1.3.0,convertRowToScalastarts returning aGenericRowWithSchema. Thus, everyGenericRowWithSchemainstance holds a separate copy of the schema object. Also, YJP profiling result of the following simple micro benchmark (executed in Spark shell) shows that constructing all these schema objects takes up to ~35% CPU time.