Skip to content

[SPARK-49688][CONNECT][TESTS] Fix a sporadic SparkConnectServiceSuite failure #48142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-49688][CONNECT][TESTS] Fix a sporadic SparkConnectServiceSuite failure #48142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1665be
Fix
Sep 18, 2024
ff683fd
Address review feedback
Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,10 +871,16 @@ class SparkConnectServiceSuite
class VerifyEvents(val sparkContext: SparkContext) {
val listener: MockSparkListener = new MockSparkListener()
val listenerBus = sparkContext.listenerBus
val EVENT_WAIT_TIMEOUT = timeout(10.seconds)
val LISTENER_BUS_TIMEOUT = 30000
def executeHolder: ExecuteHolder = {
assert(listener.executeHolder.isDefined)
listener.executeHolder.get
// An ExecuteHolder shall be set eventually through MockSparkListener
Eventually.eventually(EVENT_WAIT_TIMEOUT) {
assert(
listener.executeHolder.isDefined,
s"No events have been posted in $EVENT_WAIT_TIMEOUT")
listener.executeHolder.get
}
}
def onNext(v: proto.ExecutePlanResponse): Unit = {
if (v.hasSchema) {
Expand All @@ -891,8 +897,10 @@ class SparkConnectServiceSuite
def onCompleted(producedRowCount: Option[Long] = None): Unit = {
assert(executeHolder.eventsManager.getProducedRowCount == producedRowCount)
// The eventsManager is closed asynchronously
Eventually.eventually(timeout(1.seconds)) {
assert(executeHolder.eventsManager.status == ExecuteStatus.Closed)
Eventually.eventually(EVENT_WAIT_TIMEOUT) {
assert(
executeHolder.eventsManager.status == ExecuteStatus.Closed,
s"Execution has not been completed in $EVENT_WAIT_TIMEOUT")
}
}
def onCanceled(): Unit = {
Expand Down