[SPARK-49688][CONNECT][TESTS] Fix a sporadic SparkConnectServiceSuite failure
#48142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jdesjean Hi, nice to meet you! Could you review this trivial change? Thanks! |
dongjoon-hyun
changed the title
SparkConnectServiceSuite failure
...ct/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
Outdated
Show resolved
Hide resolved
Member
|
Also, cc @hvanhovell , too. |
HyukjinKwon
approved these changes
Sep 19, 2024
Member
|
Merged to master. |
Member
|
Thank you, @changgyoopark-db and @HyukjinKwon . |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a short wait loop to ensure that the test pre-condition is met. To be specific, VerifyEvents.executeHolder is set asynchronously by MockSparkListener.onOtherEvent whereas the test assumes that VerifyEvents.executeHolder is always available.
Why are the changes needed?
For smoother development experience.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
SparkConnectServiceSuite.
Was this patch authored or co-authored using generative AI tooling?
No.