Skip to content

[SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2 #47241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2 #47241

wants to merge 2 commits into from

Conversation

@wayneguow
Copy link
Contributor

@wayneguow wayneguow commented Jul 6, 2024 •
edited
Loading

What changes were proposed in this pull request?

This PR amis to upgrade fasterxml.jackson from 2.17.1 to 2.17.2.

Why are the changes needed?

There are some bug fixes about Databind:
#4561: Issues using jackson-databind 2.17.1 with Reactor (wrt DeserializerCache and ReentrantLock)
#4575: StdDelegatingSerializer does not consider a Converter that may return null for a non-null input
#4577: Cannot deserialize value of type java.math.BigDecimal from String "3." (not a valid representation)
#4595: No way to explicitly disable wrapping in custom annotation processor
#4607: MismatchedInput: No Object Id found for an instance of X to assign to property '@id'
#4610: DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS does not work when used with Polymorphic type handling

The full release note of 2.17.2:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.2

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jul 6, 2024
@wayneguow wayneguow marked this pull request as ready for review July 8, 2024 02:20
@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 8, 2024

What modifications are related to Spark? Can you add some details in the PR description?

@wayneguow
Copy link
Contributor Author

wayneguow commented Jul 8, 2024

@LuciferYang Thank you for the guidance, let me do some in-depth inspection and update it.

@LuciferYang LuciferYang mentioned this pull request Jul 8, 2024
Closed
@wayneguow
Copy link
Contributor Author

wayneguow commented Jul 9, 2024

@LuciferYang Updated it. And there is jackson-datatype-jdk8/2.17.0//jackson-datatype-jdk8-2.17.0.jar which is involved by parquet 1.14.1, I think there is no need to update it. WDYT?

@LuciferYang LuciferYang changed the title [SPARK-48826]BUILD] Upgrade fasterxml.jackson to 2.17.2 [SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2 Jul 9, 2024
@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 9, 2024

Merged into master. Thanks @wayneguow

@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 9, 2024

@LuciferYang Updated it. And there is jackson-datatype-jdk8/2.17.0//jackson-datatype-jdk8-2.17.0.jar which is involved by parquet 1.14.1, I think there is no need to update it. WDYT?

We can submit an independent pr to try defining additional versions of this dependency.

ericm-db pushed a commit to ericm-db/spark that referenced this pull request Jul 10, 2024
@wayneguow @ericm-db
[SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2
3d54034 
### What changes were proposed in this pull request?

This PR amis to upgrade `fasterxml.jackson` from 2.17.1 to 2.17.2.

### Why are the changes needed?

There are some bug fixes about [Databind](https://github.com/FasterXML/jackson-databind):
[apache#4561](FasterXML/jackson-databind#4561): Issues using jackson-databind 2.17.1 with Reactor (wrt DeserializerCache and ReentrantLock)
[apache#4575](FasterXML/jackson-databind#4575): StdDelegatingSerializer does not consider a Converter that may return null for a non-null input
[apache#4577](FasterXML/jackson-databind#4577): Cannot deserialize value of type java.math.BigDecimal from String "3." (not a valid representation)
[apache#4595](FasterXML/jackson-databind#4595): No way to explicitly disable wrapping in custom annotation processor
[apache#4607](FasterXML/jackson-databind#4607): MismatchedInput: No Object Id found for an instance of X to assign to property 'id'
[apache#4610](FasterXML/jackson-databind#4610): DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS does not work when used with Polymorphic type handling

The full release note of 2.17.2:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47241 from wayneguow/upgrade_jackson.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
@wayneguow @jingz-db
[SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2
ca24fc0 
### What changes were proposed in this pull request?

This PR amis to upgrade `fasterxml.jackson` from 2.17.1 to 2.17.2.

### Why are the changes needed?

There are some bug fixes about [Databind](https://github.com/FasterXML/jackson-databind):
[apache#4561](FasterXML/jackson-databind#4561): Issues using jackson-databind 2.17.1 with Reactor (wrt DeserializerCache and ReentrantLock)
[apache#4575](FasterXML/jackson-databind#4575): StdDelegatingSerializer does not consider a Converter that may return null for a non-null input
[apache#4577](FasterXML/jackson-databind#4577): Cannot deserialize value of type java.math.BigDecimal from String "3." (not a valid representation)
[apache#4595](FasterXML/jackson-databind#4595): No way to explicitly disable wrapping in custom annotation processor
[apache#4607](FasterXML/jackson-databind#4607): MismatchedInput: No Object Id found for an instance of X to assign to property 'id'
[apache#4610](FasterXML/jackson-databind#4610): DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS does not work when used with Polymorphic type handling

The full release note of 2.17.2:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47241 from wayneguow/upgrade_jackson.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
@wayneguow @attilapiros
[SPARK-48826][BUILD] Upgrade fasterxml.jackson to 2.17.2
5e9b6a4 
### What changes were proposed in this pull request?

This PR amis to upgrade `fasterxml.jackson` from 2.17.1 to 2.17.2.

### Why are the changes needed?

There are some bug fixes about [Databind](https://github.com/FasterXML/jackson-databind):
[apache#4561](FasterXML/jackson-databind#4561): Issues using jackson-databind 2.17.1 with Reactor (wrt DeserializerCache and ReentrantLock)
[apache#4575](FasterXML/jackson-databind#4575): StdDelegatingSerializer does not consider a Converter that may return null for a non-null input
[apache#4577](FasterXML/jackson-databind#4577): Cannot deserialize value of type java.math.BigDecimal from String "3." (not a valid representation)
[apache#4595](FasterXML/jackson-databind#4595): No way to explicitly disable wrapping in custom annotation processor
[apache#4607](FasterXML/jackson-databind#4607): MismatchedInput: No Object Id found for an instance of X to assign to property 'id'
[apache#4610](FasterXML/jackson-databind#4610): DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS does not work when used with Polymorphic type handling

The full release note of 2.17.2:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47241 from wayneguow/upgrade_jackson.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
@wayneguow wayneguow deleted the upgrade_jackson branch February 11, 2025 04:25
turboFei pushed a commit to turboFei/spark that referenced this pull request Nov 6, 2025
@wangyum @panbingkun @wayneguow
[HADP-54080][SPARK-48826] Upgrade jackson-databind to 2.17.2 (apache#433
1529945 
)

* [SPARK-45967][BUILD] Upgrade jackson to 2.16.0

### What changes were proposed in this pull request?
The pr aims to upgrade FasterXML jackson from 2.15.2 to 2.16.0.

### Why are the changes needed?
New version that fix some bugs, release notes as follows:
- 2.1.6.0 https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16, eg:
[Databind](https://github.com/FasterXML/jackson-databind) [apache#1770](FasterXML/jackson-databind#1770): Incorrect deserialization for BigDecimal numbers
- 2.15.3 https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15.3, eg:
[Databind](https://github.com/FasterXML/jackson-databind) [apache#3968](FasterXML/jackson-databind#3968): Records with additional constructors failed to deserialize

The last upgrade occurred 6 months ago, apache#41414

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#43859 from panbingkun/SPARK-45967.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>

(cherry picked from commit c17b092)

* [SPARK-48826][BUILD] Upgrade `fasterxml.jackson` to 2.17.2

### What changes were proposed in this pull request?

This PR amis to upgrade `fasterxml.jackson` from 2.17.1 to 2.17.2.

### Why are the changes needed?

There are some bug fixes about [Databind](https://github.com/FasterXML/jackson-databind):
[apache#4561](FasterXML/jackson-databind#4561): Issues using jackson-databind 2.17.1 with Reactor (wrt DeserializerCache and ReentrantLock)
[apache#4575](FasterXML/jackson-databind#4575): StdDelegatingSerializer does not consider a Converter that may return null for a non-null input
[apache#4577](FasterXML/jackson-databind#4577): Cannot deserialize value of type java.math.BigDecimal from String "3." (not a valid representation)
[apache#4595](FasterXML/jackson-databind#4595): No way to explicitly disable wrapping in custom annotation processor
[apache#4607](FasterXML/jackson-databind#4607): MismatchedInput: No Object Id found for an instance of X to assign to property 'id'
[apache#4610](FasterXML/jackson-databind#4610): DeserializationFeature.FAIL_ON_UNRESOLVED_OBJECT_IDS does not work when used with Polymorphic type handling

The full release note of 2.17.2:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.17.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47241 from wayneguow/upgrade_jackson.

Authored-by: Wei Guo <[email protected]>
Signed-off-by: yangjie01 <[email protected]>

(cherry picked from commit 65daff5)

* fix

---------

Co-authored-by: panbingkun <[email protected]>
Co-authored-by: Wei Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuciferYang LuciferYang LuciferYang approved these changes

Assignees

No one assigned

Labels

BUILD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wayneguow @LuciferYang