Skip to content

[SPARK-5756][SQL] Analyzer should not throw scala.NotImplementedError for illegitimate sql #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-5756][SQL] Analyzer should not throw scala.NotImplementedError for illegitimate sql #4552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ case class Alias(child: Expression, name: String)
}
}

override def toString: String = s"$child AS $name#${exprId.id}$typeSuffix"
override def toString: String = s"$child AS $name#${exprId.id}"

override protected final def otherCopyArgs = exprId :: qualifiers :: Nil
}
Expand Down
8 changes: 7 additions & 1 deletion sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import scala.util.Try
import org.apache.hadoop.hive.conf.HiveConf.ConfVars

import org.apache.spark.{SparkFiles, SparkException}
import org.apache.spark.sql.{DataFrame, Row}
import org.apache.spark.sql.{AnalysisException, DataFrame, Row}
import org.apache.spark.sql.catalyst.plans.logical.Project
import org.apache.spark.sql.Dsl._
import org.apache.spark.sql.hive._
Expand Down Expand Up @@ -575,6 +575,12 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
}
}

test("analyzer should not throw NotImplementedError") {
intercept[AnalysisException] {
sql("SELECT CAST(x AS STRING) FROM src").collect()
}
}

def isExplanation(result: DataFrame) = {
val explanation = result.select('plan).collect().map { case Row(plan: String) => plan }
explanation.contains("== Physical Plan ==")
Expand Down