[SPARK-5756][SQL] Analyzer should not throw scala.NotImplementedError for illegitimate sql

[scwf]

SELECT CAST(x AS STRING) FROM src comes a NotImplementedError:

CliDriver: scala.NotImplementedError: an implementation is missing
at scala.Predef$.$qmark$qmark$qmark(Predef.scala:252)
at org.apache.spark.sql.catalyst.expressions.PrettyAttribute.dataType(namedExpressions.scala:221)
at org.apache.spark.sql.catalyst.expressions.Cast.resolved$lzycompute(Cast.scala:30)
at org.apache.spark.sql.catalyst.expressions.Cast.resolved(Cast.scala:30)
at org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$childrenResolved$1.apply(Expression.scala:68)
at org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$childrenResolved$1.apply(Expression.scala:68)
at scala.collection.LinearSeqOptimized$class.exists(LinearSeqOptimized.scala:80)
at scala.collection.immutable.List.exists(List.scala:84)
at org.apache.spark.sql.catalyst.expressions.Expression.childrenResolved(Expression.scala:68)
at org.apache.spark.sql.catalyst.expressions.Expression.resolved$lzycompute(Expression.scala:56)
at org.apache.spark.sql.catalyst.expressions.Expression.resolved(Expression.scala:56)
at org.apache.spark.sql.catalyst.expressions.NamedExpression.typeSuffix(namedExpressions.scala:62)
at org.apache.spark.sql.catalyst.expressions.Alias.toString(namedExpressions.scala:124)
at org.apache.spark.sql.catalyst.expressions.Expression.prettyString(Expression.scala:78)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1$$anonfun$7.apply(Analyzer.scala:83)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1$$anonfun$7.apply(Analyzer.scala:83)
at scala.collection.immutable.Stream.map(Stream.scala:376)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1.applyOrElse(Analyzer.scala:83)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1.applyOrElse(Analyzer.scala:81)
at org.apache.spark.sql.catalyst.trees.TreeNode.transformUp(TreeNode.scala:204)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$.apply(Analyzer.scala:81)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$.apply(Analyzer.scala:79)

[SparkQA]

Test build #27327 has started for PR 4552 at commit 58690c0.

• This patch merges cleanly.

[scwf]

maybe we should catch the exception in typeSuffix to fix this

[SparkQA]

Test build #27327 has finished for PR 4552 at commit 58690c0.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27327/
Test PASSed.

[marmbrus]

I think this is fixed now by #4558