[SPARK-44481][CONNECT][PYTHON] Make pyspark.sql.is_remote an API #42072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
reviewed
Jul 19, 2023
| "DataFrameWriter", | ||
| "DataFrameWriterV2", | ||
| "PandasCogroupedOps", | ||
| "is_remote", |
Contributor
There was a problem hiding this comment.
Can we expose this as pyspark.sql.utils.is_remote?
Member
Author
There was a problem hiding this comment.
I think we should just expose it under pyspark.sql because APIs are usually exposed under that namespace. I think you can use it as:
is_remote = getattr(pyspark.sql, "is_remote", getattr(pyspark.sql.utils, "is_remote", None))()
Member
Author
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to expose and document
pyspark.sql.is_remoteas an API.Why are the changes needed?
For the end users to be able to do if-else, e.g., for dispatching the code path to the legacy mode or connect mode.
Does this PR introduce any user-facing change?
Yes, it exposes a method as an API.
How was this patch tested?
Manually built and checked the documentation.