[SPARK-39740][UI]: Upgrade vis timeline to 7.7.2 to fix CVE-2020-28487 #41613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrprasa
force-pushed
the
upgrade_vis
branch
2 times, most recently
from
21376f9 to
aa7143e
Compare
Contributor
Author
|
@sarutak @gengliangwang Can you please review this PR? |
Member
|
Looks OK; try rerunning tests to be sure |
Member
|
@shrprasa Sorry for the late reply. |
Contributor
Author
|
@sarutak I didn't find any performance issue with newer version of vis. I had tested the same operation which was mentioned in the PR to downgrade vis last time(#28811) Even after following operation: |
Contributor
Author
|
@srowen All tests passed on retry. |
Contributor
Author
Member
|
Merged to master |
Contributor
Author
Thanks @srowen |
senthh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Sep 2, 2024
…020-28487 ### What changes were proposed in this pull request? Upgrade vis timeline to 7.7.2 Have to add xss option with whitelisting to make the timeline work after the xss protection was added in vis-timeline. (Refer to visjs/vis-timeline#1010) ### Why are the changes needed? To remediate CVE-2020-28487 GHSA-9mrv-456v-pf22 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually by running spark-shell and checking History Server UI. Timeline rendered successfully and no change in style. Even after following operation: (1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect) UI loaded in 3 seconds faster than it loaded with 4.21. Closes apache#41613 from shrprasa/upgrade_vis. Authored-by: Shrikant Prasad <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit a8ea35f)
senthh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Nov 12, 2024
…020-28487 ### What changes were proposed in this pull request? Upgrade vis timeline to 7.7.2 Have to add xss option with whitelisting to make the timeline work after the xss protection was added in vis-timeline. (Refer to visjs/vis-timeline#1010) ### Why are the changes needed? To remediate CVE-2020-28487 GHSA-9mrv-456v-pf22 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually by running spark-shell and checking History Server UI. Timeline rendered successfully and no change in style. Even after following operation: (1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect) UI loaded in 3 seconds faster than it loaded with 4.21. Closes apache#41613 from shrprasa/upgrade_vis. Authored-by: Shrikant Prasad <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit a8ea35f)
senthh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Nov 13, 2024
…020-28487 ### What changes were proposed in this pull request? Upgrade vis timeline to 7.7.2 Have to add xss option with whitelisting to make the timeline work after the xss protection was added in vis-timeline. (Refer to visjs/vis-timeline#1010) ### Why are the changes needed? To remediate CVE-2020-28487 GHSA-9mrv-456v-pf22 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually by running spark-shell and checking History Server UI. Timeline rendered successfully and no change in style. Even after following operation: (1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect) UI loaded in 3 seconds faster than it loaded with 4.21. Closes apache#41613 from shrprasa/upgrade_vis. Authored-by: Shrikant Prasad <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit a8ea35f)
senthh
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Nov 13, 2024
…020-28487 ### What changes were proposed in this pull request? Upgrade vis timeline to 7.7.2 Have to add xss option with whitelisting to make the timeline work after the xss protection was added in vis-timeline. (Refer to visjs/vis-timeline#1010) ### Why are the changes needed? To remediate CVE-2020-28487 GHSA-9mrv-456v-pf22 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually by running spark-shell and checking History Server UI. Timeline rendered successfully and no change in style. Even after following operation: (1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect) UI loaded in 3 seconds faster than it loaded with 4.21. Closes apache#41613 from shrprasa/upgrade_vis. Authored-by: Shrikant Prasad <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit a8ea35f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade vis timeline to 7.7.2
Have to add xss option with whitelisting to make the timeline work after the xss protection was added in vis-timeline.
(Refer to visjs/vis-timeline#1010)
Why are the changes needed?
To remediate CVE-2020-28487
GHSA-9mrv-456v-pf22
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually by running spark-shell and checking History Server UI.
Timeline rendered successfully and no change in style.
Even after following operation:
(1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect)
UI loaded in 3 seconds faster than it loaded with 4.21.