[SPARK-42896][SQL][PYTHON][FOLLOW-UP] Rename isBarrier to barrier, and correct docstring #40571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @WeichenXu123 and @ueshin |
ueshin
approved these changes
Mar 28, 2023
yaooqinn
approved these changes
Mar 28, 2023
Member
Author
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 29, 2023
### What changes were proposed in this pull request? This is a follow-up of #40559 and #40571. Renames `isBarrier` to `barrier` in Spark Connect, too. ### Why are the changes needed? #40571 changed the argument name from `isBarrier` to `barrier`, so Spark Connect should follow it. ### Does this PR introduce _any_ user-facing change? Yes, it renames the parameter. ### How was this patch tested? Existing tests. Closes #40579 from ueshin/issues/SPARK-42929/barrier. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of proposes to fix:
versionchangedin its docstring.isBarriertobarrierto make it look Python friendlyWhy are the changes needed?
For better documentation, and make it more Python friendly.
Does this PR introduce any user-facing change?
Yes, it renames the parameter, and fixes the documentation.
How was this patch tested?
Linters in this PR should test them out.