Skip to content

[SPARK-42698][CORE] SparkSubmit should also stop SparkContext when exit program in yarn mode and pass exitCode to AM side #40314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-42698][CORE] SparkSubmit should also stop SparkContext when exit program in yarn mode and pass exitCode to AM side #40314

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ca0fdc
[SPARK-42698][CORE] SparkSubmit should pass exitCode to AM side
AngersZhuuuu Mar 7, 2023
3b3e40e
Update SparkSubmit.scala
AngersZhuuuu Mar 7, 2023
2ca2244
Update SparkSubmit.scala
AngersZhuuuu Mar 8, 2023
2882a0b
trigger
AngersZhuuuu Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,17 +1005,20 @@ private[spark] class SparkSubmit extends Logging {
e
}

var exitCode = 0

try {
app.start(childArgs.toArray, sparkConf)
} catch {
case t: Throwable =>
exitCode = -1
throw findCause(t)
} finally {
if (args.master.startsWith("k8s") && !isShell(args.primaryResource) &&
!isSqlShell(args.mainClass) && !isThriftServer(args.mainClass) &&
!isConnectServer(args.mainClass)) {
if ((args.master.startsWith("k8s") || args.master.startsWith("yarn")) &&
!isShell(args.primaryResource) && !isSqlShell(args.mainClass) &&
!isThriftServer(args.mainClass) && !isConnectServer(args.mainClass)) {
try {
SparkContext.getActive.foreach(_.stop())
SparkContext.getActive.foreach(_.stop(exitCode))
Copy link
Member

@dongjoon-hyun dongjoon-hyun Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is related to YARN AM because this is guarded by if (args.master.startsWith("k8s"). Is this K8s patch instead of YARN AM?

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in spark-3.1.2 is

      if (!isShell(args.primaryResource) && !isSqlShell(args.mainClass) &&
        !isThriftServer(args.mainClass)) {

Seems #33403 change the behavior

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know too much about K8S scheduler, but for yarn client mode we also need to keep a same exit code.

} catch {
case e: Throwable => logError(s"Failed to close SparkContext: $e")
}
Expand Down