Skip to content

[SPARK-42157][CORE] spark.scheduler.mode=FAIR should provide FAIR scheduler #39703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[SPARK-42157][CORE] spark.scheduler.mode=FAIR should provide FAIR scheduler #39703

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
273a3a6
[SPARK-42157][CORE] spark.scheduler.mode=FAIR should provide FAIR sch…
dongjoon-hyun Jan 22, 2023
17db356
Fix info log message
dongjoon-hyun Jan 23, 2023
7fc9906
Revert "Fix info log message"
dongjoon-hyun Jan 23, 2023
664e4f7
Revert "[SPARK-42157][CORE] spark.scheduler.mode=FAIR should provide …
dongjoon-hyun Jan 23, 2023
e0d22d6
Address comments
dongjoon-hyun Jan 23, 2023
58082c9
Update core/src/main/scala/org/apache/spark/scheduler/SchedulableBuil…
dongjoon-hyun Jan 24, 2023
5124297
Indentation
dongjoon-hyun Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import org.apache.hadoop.fs.Path

import org.apache.spark.SparkContext
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config.SCHEDULER_ALLOCATION_FILE
import org.apache.spark.internal.config.{SCHEDULER_ALLOCATION_FILE, SCHEDULER_MODE}
import org.apache.spark.scheduler.SchedulingMode.SchedulingMode
import org.apache.spark.util.Utils

Expand Down Expand Up @@ -86,9 +86,12 @@ private[spark] class FairSchedulableBuilder(val rootPool: Pool, sc: SparkContext
logInfo(s"Creating Fair Scheduler pools from default file: $DEFAULT_SCHEDULER_FILE")
Some((is, DEFAULT_SCHEDULER_FILE))
} else {
logWarning("Fair Scheduler configuration file not found so jobs will be scheduled in " +
s"FIFO order. To use fair scheduling, configure pools in $DEFAULT_SCHEDULER_FILE or " +
s"set ${SCHEDULER_ALLOCATION_FILE.key} to a file that contains the configuration.")
val schedulingMode = SchedulingMode.withName(sc.conf.get(SCHEDULER_MODE))
rootPool.addSchedulable(new Pool(
DEFAULT_POOL_NAME, schedulingMode, DEFAULT_MINIMUM_SHARE, DEFAULT_WEIGHT))
logInfo("Fair scheduler configuration not found, created default pool: " +
"%s, schedulingMode: %s, minShare: %d, weight: %d".format(
DEFAULT_POOL_NAME, schedulingMode, DEFAULT_MINIMUM_SHARE, DEFAULT_WEIGHT))
None
}
}
Expand Down