[SPARK-39704][SQL] Implement createIndex & dropIndex & indexExists in JDBC (H2 dialect) #37112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JDBC (H2 dialect)
Contributor
Author
|
ping @huaxingao |
huaxingao
reviewed
Jul 8, 2022
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
Outdated
Show resolved
Hide resolved
huaxingao
reviewed
Jul 8, 2022
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
Outdated
Show resolved
Hide resolved
… JDBC (H2 dialect)
… JDBC (H2 dialect)
|
Can one of the admins verify this patch? |
huaxingao
reviewed
Jul 9, 2022
huaxingao
reviewed
Jul 9, 2022
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
Outdated
Show resolved
Hide resolved
huaxingao
reviewed
Jul 9, 2022
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
Outdated
Show resolved
Hide resolved
huaxingao
reviewed
Jul 9, 2022
huaxingao
reviewed
Jul 9, 2022
… JDBC (H2 dialect)
huaxingao
approved these changes
Jul 12, 2022
Contributor
|
Merged to master. Thanks @panbingkun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implementing createIndex/dropIndex/indexExists in DS V2 JDBC for H2 dialect.
Why are the changes needed?
This is a subtask of the V2 Index support(https://issues.apache.org/jira/browse/SPARK-36525).
This PR implements createIndex, dropIndex and indexExists.
After review for some changes in this PR, I will create new PR for listIndexs.
It can better test the index interface locally.
Does this PR introduce any user-facing change?
Yes, createIndex/dropIndex/indexExists in DS V2 JDBC for H2
How was this patch tested?
New UT.