Skip to content

[SPARK-38198][SQL][3.2] Fix QueryExecution.debug#toFile use the passed in maxFields when explainMode is CodegenMode #35515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-38198][SQL][3.2] Fix QueryExecution.debug#toFile use the passed in maxFields when explainMode is CodegenMode #35515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,6 @@ class QueryExecution(
}

private def stringWithStats(maxFields: Int, append: String => Unit): Unit = {
val maxFields = SQLConf.get.maxToStringFields

// trigger to compute stats for logical plans
try {
// This will trigger to compute stats for all the nodes in the plan, including subqueries,
Expand Down
18 changes: 18 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,4 +264,22 @@ class QueryExecutionSuite extends SharedSparkSession {
assert(cmdResultExec.commandPhysicalPlan.asInstanceOf[ExecutedCommandExec]
.cmd.isInstanceOf[ShowTablesCommand])
}

test("SPARK-38198: check specify maxFields when call toFile method") {
withTempDir { dir =>
val path = dir.getCanonicalPath + "/plans.txt"
// Define a dataset with 6 columns
val ds = spark.createDataset(Seq((0, 1, 2, 3, 4, 5), (6, 7, 8, 9, 10, 11)))
// `CodegenMode` and `FormattedMode` doesn't use the maxFields, so not tested in this case
Seq(SimpleMode.name, ExtendedMode.name, CostMode.name).foreach { modeName =>
val maxFields = 3
ds.queryExecution.debug.toFile(path, explainMode = Some(modeName), maxFields = maxFields)
Utils.tryWithResource(Source.fromFile(path)) { source =>
val tableScan = source.getLines().filter(_.contains("LocalTableScan"))
assert(tableScan.exists(_.contains("more fields")),
s"Specify maxFields = $maxFields doesn't take effect when explainMode is $modeName")
}
}
}
}
}